From 7c72b5791b114e173130aa95d8de891057324cea Mon Sep 17 00:00:00 2001 From: SenXuDC Date: Sat, 25 Jan 2020 10:51:55 +0800 Subject: [PATCH] fix static check in pkg/volume/flocker --- hack/.staticcheck_failures | 1 - pkg/volume/flocker/flocker.go | 1 - pkg/volume/flocker/flocker_volume_test.go | 4 ++-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index ffaa4e8baa4..bb731b37f5a 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -23,7 +23,6 @@ pkg/volume/azure_file pkg/volume/csi pkg/volume/fc pkg/volume/flexvolume -pkg/volume/flocker pkg/volume/iscsi pkg/volume/local pkg/volume/portworx diff --git a/pkg/volume/flocker/flocker.go b/pkg/volume/flocker/flocker.go index 723b28de4db..413f275c722 100644 --- a/pkg/volume/flocker/flocker.go +++ b/pkg/volume/flocker/flocker.go @@ -394,7 +394,6 @@ func (b *flockerVolumeMounter) updateDatasetPrimary(datasetUUID string, primaryU datasetUUID, primaryUUID, err, ) case <-tickChan.C: - break } } diff --git a/pkg/volume/flocker/flocker_volume_test.go b/pkg/volume/flocker/flocker_volume_test.go index a8e58788fa0..9964f1ed143 100644 --- a/pkg/volume/flocker/flocker_volume_test.go +++ b/pkg/volume/flocker/flocker_volume_test.go @@ -85,7 +85,7 @@ func TestProvision(t *testing.T) { dir, provisioner = newTestableProvisioner(t, assert, options) defer os.RemoveAll(dir) - persistentSpec, err = provisioner.Provision(nil, nil) + _, err = provisioner.Provision(nil, nil) assert.Error(err, "Provision() did not fail with Parameters specified") // selectors are not supported @@ -97,6 +97,6 @@ func TestProvision(t *testing.T) { dir, provisioner = newTestableProvisioner(t, assert, options) defer os.RemoveAll(dir) - persistentSpec, err = provisioner.Provision(nil, nil) + _, err = provisioner.Provision(nil, nil) assert.Error(err, "Provision() did not fail with Selector specified") }