github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 04:06:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #111403 from wujunwei/kubectl-check-command-before-copy

Browse Source 
kubectl: remove unnecessary TODO annotations
This commit is contained in:
Kubernetes Prow Robot 2022-12-09 15:41:52 -08:00 committed by GitHub
commit 1820caea93
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/kubectl/pkg/cmd/cp/cp.go
View File

@ -304,7 +304,6 @@ func (o *CopyOptions) copyToPod(src, dest fileSpec, options *exec.ExecOptions) e
}(srcFile, destFile, writer) }(srcFile, destFile, writer)
var cmdArr []string var cmdArr []string
// TODO: Improve error messages by first testing if 'tar' is present in the container?
if o.NoPreserve { if o.NoPreserve {
cmdArr = []string{"tar", "--no-same-permissions", "--no-same-owner", "-xmf", "-"} cmdArr = []string{"tar", "--no-same-permissions", "--no-same-owner", "-xmf", "-"}
} else { } else {
@ -373,7 +372,6 @@ func (t *TarPipe) initReadFrom(n uint64) {
PodName: t.src.PodName, PodName: t.src.PodName,
}, },
// TODO: Improve error messages by first testing if 'tar' is present in the container?
Command: []string{"tar", "cf", "-", t.src.File.String()}, Command: []string{"tar", "cf", "-", t.src.File.String()},
Executor: &exec.DefaultRemoteExecutor{}, Executor: &exec.DefaultRemoteExecutor{},
} }