github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 12:07:47 +00:00
Code Issues Projects Releases Wiki Activity

API warn non-ExternalName services w/ externalName

Browse Source
This commit is contained in:
Tim Hockin 2023-07-13 18:58:09 -07:00
parent 7bd0a857e3
commit 182a4f858a
No known key found for this signature in database
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/api/service/warnings.go
View File

@ -56,6 +56,9 @@ func GetWarningsForService(service, oldService *api.Service) []string {
if service.Spec.Type == api.ServiceTypeExternalName && len(service.Spec.ExternalIPs) > 0 { if service.Spec.Type == api.ServiceTypeExternalName && len(service.Spec.ExternalIPs) > 0 {
warnings = append(warnings, fmt.Sprintf("spec.externalIPs is ignored when spec.type is %q", api.ServiceTypeExternalName)) warnings = append(warnings, fmt.Sprintf("spec.externalIPs is ignored when spec.type is %q", api.ServiceTypeExternalName))
} }
if service.Spec.Type != api.ServiceTypeExternalName && service.Spec.ExternalName != "" {
warnings = append(warnings, fmt.Sprintf("spec.externalName is ignored when spec.type is not %q", api.ServiceTypeExternalName))
}
return warnings return warnings
} }

11
pkg/api/service/warnings_test.go
View File

@ -50,6 +50,13 @@ func TestGetWarningsForService(t *testing.T) {
s.Spec.ExternalIPs = []string{"1.2.3.4"} s.Spec.ExternalIPs = []string{"1.2.3.4"}
}, },
numWarnings: 1, numWarnings: 1,
}, {
name: "externalName set when type is not ExternalName",
tweakSvc: func(s *api.Service) {
s.Spec.Type = api.ServiceTypeClusterIP
s.Spec.ExternalName = "example.com"
},
numWarnings: 1,
}} }}
for _, tc := range testCases { for _, tc := range testCases {
@ -57,8 +64,8 @@ func TestGetWarningsForService(t *testing.T) {
svc := &api.Service{} svc := &api.Service{}
tc.tweakSvc(svc) tc.tweakSvc(svc)
warnings := GetWarningsForService(svc, svc) warnings := GetWarningsForService(svc, svc)
if len(warnings) != tc.numWarnings { if want, got := tc.numWarnings, len(warnings); got != want {
t.Errorf("Unexpected warning list: %v", warnings) t.Errorf("Unexpected warning list: expected %d, got %d\n%q", want, got, warnings)
} }
}) })
} }