From 7c4c321c9899ebe0c8cb21477f47d9f9743ddf19 Mon Sep 17 00:00:00 2001 From: Yu Liao Date: Tue, 12 Dec 2017 12:55:20 -0800 Subject: [PATCH 1/2] added defaults for --watch-cache-sizes description. --- staging/src/k8s.io/apiserver/pkg/server/options/etcd.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go b/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go index d522cde9bcb..9bfa3a0a778 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go +++ b/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go @@ -120,7 +120,8 @@ func (s *EtcdOptions) AddFlags(fs *pflag.FlagSet) { fs.StringSliceVar(&s.WatchCacheSizes, "watch-cache-sizes", s.WatchCacheSizes, ""+ "List of watch cache sizes for every resource (pods, nodes, etc.), comma separated. "+ "The individual override format: resource#size, where size is a number. It takes effect "+ - "when watch-cache is enabled.") + "when watch-cache is enabled. Some resources (replicationcontrollers, endpoints, nodes, pods, services, apiservices) "+ + "have system defaults set by heuristics, others default to default-watch-cache-size") fs.StringVar(&s.StorageConfig.Type, "storage-backend", s.StorageConfig.Type, "The storage backend for persistence. Options: 'etcd3' (default), 'etcd2'.") From 18d24d8303e2078260ec34ca8fb4b1a83bb585d7 Mon Sep 17 00:00:00 2001 From: Yu Liao Date: Wed, 13 Dec 2017 12:39:37 -0800 Subject: [PATCH 2/2] added more description for flag '--watch-cache-sizes' to make the format of the flag clearer. --- staging/src/k8s.io/apiserver/pkg/server/options/etcd.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go b/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go index 9bfa3a0a778..4d5d1bc22ad 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go +++ b/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go @@ -119,8 +119,9 @@ func (s *EtcdOptions) AddFlags(fs *pflag.FlagSet) { fs.StringSliceVar(&s.WatchCacheSizes, "watch-cache-sizes", s.WatchCacheSizes, ""+ "List of watch cache sizes for every resource (pods, nodes, etc.), comma separated. "+ - "The individual override format: resource#size, where size is a number. It takes effect "+ - "when watch-cache is enabled. Some resources (replicationcontrollers, endpoints, nodes, pods, services, apiservices) "+ + "The individual override format: resource[.group]#size, where resource is lowercase plural (no version), "+ + "group is optional, and size is a number. It takes effect when watch-cache is enabled. "+ + "Some resources (replicationcontrollers, endpoints, nodes, pods, services, apiservices.apiregistration.k8s.io) "+ "have system defaults set by heuristics, others default to default-watch-cache-size") fs.StringVar(&s.StorageConfig.Type, "storage-backend", s.StorageConfig.Type,