github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #76707 from soltysh/bug1695225

Browse Source 
Warn to stderr when we encounter PathError listing plugins
This commit is contained in:
Kubernetes Prow Robot 2019-04-17 13:41:08 -07:00 committed by GitHub
commit 18b4e1b84c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/kubectl/cmd/plugin/BUILD
View File

@ -11,7 +11,6 @@ go_library(
"//pkg/kubectl/util/templates:go_default_library", "//pkg/kubectl/util/templates:go_default_library",
"//staging/src/k8s.io/cli-runtime/pkg/genericclioptions:go_default_library", "//staging/src/k8s.io/cli-runtime/pkg/genericclioptions:go_default_library",
"//vendor/github.com/spf13/cobra:go_default_library", "//vendor/github.com/spf13/cobra:go_default_library",
"//vendor/k8s.io/klog:go_default_library",
], ],
) )

5
pkg/kubectl/cmd/plugin/plugin.go
View File

@ -28,7 +28,6 @@ import (
"github.com/spf13/cobra" "github.com/spf13/cobra"
"k8s.io/cli-runtime/pkg/genericclioptions" "k8s.io/cli-runtime/pkg/genericclioptions"
"k8s.io/klog"
cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
"k8s.io/kubernetes/pkg/kubectl/util/i18n" "k8s.io/kubernetes/pkg/kubectl/util/i18n"
"k8s.io/kubernetes/pkg/kubectl/util/templates" "k8s.io/kubernetes/pkg/kubectl/util/templates"
@ -116,8 +115,8 @@ func (o *PluginListOptions) Run() error {
for _, dir := range uniquePathsList(o.PluginPaths) { for _, dir := range uniquePathsList(o.PluginPaths) {
files, err := ioutil.ReadDir(dir) files, err := ioutil.ReadDir(dir)
if err != nil { if err != nil {
if _, ok := err.(*os.PathError); ok && strings.Contains(err.Error(), "no such file") { if _, ok := err.(*os.PathError); ok {
klog.V(3).Infof("unable to find directory %q in your PATH. Skipping...", dir) fmt.Fprintf(o.ErrOut, "Unable read directory %q from your PATH: %v. Skipping...", dir, err)
continue continue
} }