From 18bf8f8616cc978cf83db800b9ccfb6910ea9895 Mon Sep 17 00:00:00 2001 From: Derek Carr Date: Wed, 31 May 2017 12:08:52 -0400 Subject: [PATCH] redudant if-block in validation code --- pkg/api/validation/validation.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/api/validation/validation.go b/pkg/api/validation/validation.go index 9eebfd268ad..c862d51f52c 100644 --- a/pkg/api/validation/validation.go +++ b/pkg/api/validation/validation.go @@ -2190,11 +2190,9 @@ func ValidatePodSpec(spec *api.PodSpec, fldPath *field.Path) field.ErrorList { } if spec.ActiveDeadlineSeconds != nil { - if spec.ActiveDeadlineSeconds != nil { - value := *spec.ActiveDeadlineSeconds - if value < 1 || value > math.MaxUint32 { - allErrs = append(allErrs, field.Invalid(fldPath.Child("activeDeadlineSeconds"), value, validation.InclusiveRangeError(1, math.MaxUint32))) - } + value := *spec.ActiveDeadlineSeconds + if value < 1 || value > math.MaxUint32 { + allErrs = append(allErrs, field.Invalid(fldPath.Child("activeDeadlineSeconds"), value, validation.InclusiveRangeError(1, math.MaxUint32))) } }