From 18c46b2487a9d69da624845b2ef84a9efc57183c Mon Sep 17 00:00:00 2001 From: Liang Deng <283304489@qq.com> Date: Wed, 26 Jul 2023 09:47:11 +0800 Subject: [PATCH] add validation for static pods to have a name Signed-off-by: Liang Deng <283304489@qq.com> --- pkg/kubelet/config/common.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/kubelet/config/common.go b/pkg/kubelet/config/common.go index 7dade01b9c3..173c7bdd39f 100644 --- a/pkg/kubelet/config/common.go +++ b/pkg/kubelet/config/common.go @@ -120,6 +120,10 @@ func tryDecodeSinglePod(data []byte, defaultFn defaultFunc) (parsed bool, pod *v return false, pod, fmt.Errorf("invalid pod: %#v", obj) } + if newPod.Name == "" { + return true, pod, fmt.Errorf("invalid pod: name is needed for the pod") + } + // Apply default values and validate the pod. if err = defaultFn(newPod); err != nil { return true, pod, err @@ -151,6 +155,9 @@ func tryDecodePodList(data []byte, defaultFn defaultFunc) (parsed bool, pods v1. // Apply default values and validate pods. for i := range newPods.Items { newPod := &newPods.Items[i] + if newPod.Name == "" { + return true, pods, fmt.Errorf("invalid pod: name is needed for the pod") + } if err = defaultFn(newPod); err != nil { return true, pods, err }