From 18e3807cd763d3d8e598756159de570a15d99c89 Mon Sep 17 00:00:00 2001 From: Kenichi Omichi Date: Sat, 27 Jul 2019 01:03:10 +0000 Subject: [PATCH] Remove duplicated check in ObserveEventAfterAction In ObserveEventAfterAction(), observedMatchingEvent is set if ok is true. Now the ok is already checked with framework.ExpectEqual(). So this removes duplicated check for code cleanup. --- test/e2e/common/events.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/common/events.go b/test/e2e/common/events.go index 30ec90bd2eb..8fd5833ef45 100644 --- a/test/e2e/common/events.go +++ b/test/e2e/common/events.go @@ -121,7 +121,7 @@ func ObserveEventAfterAction(f *framework.Framework, eventPredicate func(*v1.Eve e, ok := obj.(*v1.Event) ginkgo.By(fmt.Sprintf("Considering event: \nType = [%s], Name = [%s], Reason = [%s], Message = [%s]", e.Type, e.Name, e.Reason, e.Message)) framework.ExpectEqual(ok, true) - if ok && eventPredicate(e) { + if eventPredicate(e) { observedMatchingEvent = true } },