From 194c22fed54ba89d985085412795a9850bedeaf3 Mon Sep 17 00:00:00 2001 From: Mike Spreitzer Date: Wed, 6 Jan 2021 12:56:16 -0500 Subject: [PATCH] Explain warnings in new test Add info message that explains what warnings are deliberate and expected. --- .../apiserver/pkg/util/flowcontrol/metrics/BUILD | 1 + .../metrics/sample_and_watermark_test.go | 13 ++++++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/BUILD b/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/BUILD index 4cea275a17d..fa038f0dcc6 100644 --- a/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/BUILD @@ -41,5 +41,6 @@ go_test( "//staging/src/k8s.io/apimachinery/pkg/util/clock:go_default_library", "//staging/src/k8s.io/component-base/metrics:go_default_library", "//staging/src/k8s.io/component-base/metrics/legacyregistry:go_default_library", + "//vendor/k8s.io/klog/v2:go_default_library", ], ) diff --git a/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/sample_and_watermark_test.go b/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/sample_and_watermark_test.go index cb21df3faa9..0b7810dcc9a 100644 --- a/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/sample_and_watermark_test.go +++ b/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/metrics/sample_and_watermark_test.go @@ -25,9 +25,15 @@ import ( "k8s.io/apimachinery/pkg/util/clock" compbasemetrics "k8s.io/component-base/metrics" "k8s.io/component-base/metrics/legacyregistry" + "k8s.io/klog/v2" ) -const samplesHistName = "sawtestsamples" +const ( + samplesHistName = "sawtestsamples" + ddtRange = 3000 + ddtOffset = 500 + numIterations = 100 +) func TestSampler(t *testing.T) { t0 := time.Now() @@ -45,9 +51,10 @@ func TestSampler(t *testing.T) { } dt := 2 * samplingPeriod t1 := t0.Add(dt) + klog.Infof("Expect about %v warnings about time going backwards; this is fake time deliberately misbehaving.", (numIterations*ddtOffset)/ddtRange) t.Logf("t0=%s", t0) - for i := 0; i < 100; i++ { - ddt := time.Microsecond * time.Duration(rand.Intn(3000)-500) + for i := 0; i < numIterations; i++ { + ddt := time.Microsecond * time.Duration(rand.Intn(ddtRange)-ddtOffset) t1 = t1.Add(ddt) diff := t1.Sub(t0) if diff > dt {