From 19ca6ca9f2cbb0056766e46a6a0c69c40d990287 Mon Sep 17 00:00:00 2001 From: Manjunath A Kumatagi Date: Fri, 30 Jun 2017 18:43:55 +0530 Subject: [PATCH] Fix review comments - luxas, ixdy --- test/images/BUILD | 6 +++--- test/images/Makefile | 2 +- test/images/clusterapi-tester/NAME | 1 - test/images/clusterapi-tester/VERSION | 2 +- .../{nvidia-cuda => cuda-vector-add}/BASEIMAGE | 0 .../{nvidia-cuda => cuda-vector-add}/Dockerfile | 0 .../{nvidia-cuda => cuda-vector-add}/README.md | 0 test/images/cuda-vector-add/VERSION | 1 + test/images/dnsutils/NAME | 1 - test/images/dnsutils/VERSION | 2 +- test/images/entrypoint-tester/NAME | 1 - test/images/entrypoint-tester/VERSION | 2 +- test/images/fakegitserver/NAME | 1 - test/images/fakegitserver/VERSION | 2 +- test/images/goproxy/NAME | 1 - test/images/goproxy/VERSION | 2 +- test/images/hostexec/NAME | 1 - test/images/hostexec/VERSION | 2 +- test/images/image-util.sh | 14 ++------------ test/images/iperf/NAME | 1 - test/images/iperf/VERSION | 2 +- test/images/jessie-dnsutils/NAME | 1 - test/images/jessie-dnsutils/VERSION | 2 +- test/images/logs-generator/NAME | 1 - test/images/logs-generator/VERSION | 2 +- test/images/mount-tester-user/BASEIMAGE | 5 ----- test/images/mount-tester-user/NAME | 1 - test/images/mount-tester-user/VERSION | 1 - test/images/mount-tester/NAME | 1 - test/images/mount-tester/VERSION | 1 - test/images/mounttest-user/BASEIMAGE | 5 +++++ .../Dockerfile | 0 test/images/mounttest-user/VERSION | 1 + test/images/{mount-tester => mounttest}/BUILD | 12 ++++++------ test/images/{mount-tester => mounttest}/Dockerfile | 0 test/images/{mount-tester => mounttest}/Makefile | 0 test/images/mounttest/VERSION | 1 + test/images/{mount-tester => mounttest}/mt.go | 0 test/images/n-way-http/NAME | 1 - test/images/n-way-http/VERSION | 2 +- test/images/net/NAME | 1 - test/images/net/VERSION | 2 +- test/images/netexec/NAME | 1 - test/images/netexec/VERSION | 2 +- test/images/{network-tester => nettest}/BUILD | 12 ++++++------ test/images/{network-tester => nettest}/Dockerfile | 0 test/images/{network-tester => nettest}/Makefile | 0 test/images/nettest/VERSION | 1 + test/images/{network-tester => nettest}/nettest.go | 0 test/images/{network-tester => nettest}/rc.json | 0 .../{network-tester => nettest}/service.json | 0 .../{network-tester => nettest}/slow-pod.json | 0 .../{network-tester => nettest}/slow-rc.json | 0 test/images/network-tester/NAME | 1 - test/images/network-tester/VERSION | 1 - test/images/no-snat-test-proxy/NAME | 1 - test/images/no-snat-test-proxy/VERSION | 2 +- test/images/no-snat-test/NAME | 1 - test/images/no-snat-test/VERSION | 2 +- test/images/nvidia-cuda/NAME | 1 - test/images/nvidia-cuda/VERSION | 1 - test/images/port-forward-tester/NAME | 1 - test/images/port-forward-tester/VERSION | 2 +- test/images/porter/NAME | 1 - test/images/porter/VERSION | 2 +- test/images/redis/NAME | 1 - test/images/redis/VERSION | 2 +- test/images/resource-consumer/NAME | 1 - test/images/resource-consumer/VERSION | 2 +- test/images/resource-consumer/controller/NAME | 1 - test/images/resource-consumer/controller/VERSION | 2 +- .../{serve_hostname => serve-hostname}/BASEIMAGE | 0 .../{serve_hostname => serve-hostname}/BUILD | 12 ++++++------ .../{serve_hostname => serve-hostname}/Dockerfile | 0 .../{serve_hostname => serve-hostname}/Makefile | 0 .../{serve_hostname => serve-hostname}/README.md | 0 test/images/serve-hostname/VERSION | 1 + .../serve_hostname.go | 0 test/images/serve_hostname/NAME | 1 - test/images/serve_hostname/VERSION | 1 - 80 files changed, 53 insertions(+), 87 deletions(-) delete mode 100644 test/images/clusterapi-tester/NAME rename test/images/{nvidia-cuda => cuda-vector-add}/BASEIMAGE (100%) rename test/images/{nvidia-cuda => cuda-vector-add}/Dockerfile (100%) rename test/images/{nvidia-cuda => cuda-vector-add}/README.md (100%) create mode 100644 test/images/cuda-vector-add/VERSION delete mode 100644 test/images/dnsutils/NAME delete mode 100644 test/images/entrypoint-tester/NAME delete mode 100644 test/images/fakegitserver/NAME delete mode 100644 test/images/goproxy/NAME delete mode 100644 test/images/hostexec/NAME delete mode 100644 test/images/iperf/NAME delete mode 100644 test/images/jessie-dnsutils/NAME delete mode 100644 test/images/logs-generator/NAME delete mode 100644 test/images/mount-tester-user/BASEIMAGE delete mode 100644 test/images/mount-tester-user/NAME delete mode 100644 test/images/mount-tester-user/VERSION delete mode 100644 test/images/mount-tester/NAME delete mode 100644 test/images/mount-tester/VERSION create mode 100644 test/images/mounttest-user/BASEIMAGE rename test/images/{mount-tester-user => mounttest-user}/Dockerfile (100%) create mode 100644 test/images/mounttest-user/VERSION rename test/images/{mount-tester => mounttest}/BUILD (95%) rename test/images/{mount-tester => mounttest}/Dockerfile (100%) rename test/images/{mount-tester => mounttest}/Makefile (100%) create mode 100644 test/images/mounttest/VERSION rename test/images/{mount-tester => mounttest}/mt.go (100%) delete mode 100644 test/images/n-way-http/NAME delete mode 100644 test/images/net/NAME delete mode 100644 test/images/netexec/NAME rename test/images/{network-tester => nettest}/BUILD (96%) rename test/images/{network-tester => nettest}/Dockerfile (100%) rename test/images/{network-tester => nettest}/Makefile (100%) create mode 100644 test/images/nettest/VERSION rename test/images/{network-tester => nettest}/nettest.go (100%) rename test/images/{network-tester => nettest}/rc.json (100%) rename test/images/{network-tester => nettest}/service.json (100%) rename test/images/{network-tester => nettest}/slow-pod.json (100%) rename test/images/{network-tester => nettest}/slow-rc.json (100%) delete mode 100644 test/images/network-tester/NAME delete mode 100644 test/images/network-tester/VERSION delete mode 100644 test/images/no-snat-test-proxy/NAME delete mode 100644 test/images/no-snat-test/NAME delete mode 100644 test/images/nvidia-cuda/NAME delete mode 100644 test/images/nvidia-cuda/VERSION delete mode 100644 test/images/port-forward-tester/NAME delete mode 100644 test/images/porter/NAME delete mode 100644 test/images/redis/NAME delete mode 100644 test/images/resource-consumer/NAME delete mode 100644 test/images/resource-consumer/controller/NAME rename test/images/{serve_hostname => serve-hostname}/BASEIMAGE (100%) rename test/images/{serve_hostname => serve-hostname}/BUILD (95%) rename test/images/{serve_hostname => serve-hostname}/Dockerfile (100%) rename test/images/{serve_hostname => serve-hostname}/Makefile (100%) rename test/images/{serve_hostname => serve-hostname}/README.md (100%) create mode 100644 test/images/serve-hostname/VERSION rename test/images/{serve_hostname => serve-hostname}/serve_hostname.go (100%) delete mode 100644 test/images/serve_hostname/NAME delete mode 100644 test/images/serve_hostname/VERSION diff --git a/test/images/BUILD b/test/images/BUILD index 4424ecf83c1..009d86244a1 100644 --- a/test/images/BUILD +++ b/test/images/BUILD @@ -23,17 +23,17 @@ filegroup( "//test/images/fakegitserver:all-srcs", "//test/images/goproxy:all-srcs", "//test/images/logs-generator:all-srcs", - "//test/images/mount-tester:all-srcs", + "//test/images/mounttest:all-srcs", "//test/images/n-way-http:all-srcs", "//test/images/net:all-srcs", "//test/images/netexec:all-srcs", - "//test/images/network-tester:all-srcs", + "//test/images/nettest:all-srcs", "//test/images/no-snat-test:all-srcs", "//test/images/no-snat-test-proxy:all-srcs", "//test/images/port-forward-tester:all-srcs", "//test/images/porter:all-srcs", "//test/images/resource-consumer:all-srcs", - "//test/images/serve_hostname:all-srcs", + "//test/images/serve-hostname:all-srcs", ], tags = ["automanaged"], ) diff --git a/test/images/Makefile b/test/images/Makefile index 9d5aeb5ebc5..450b17beb7c 100644 --- a/test/images/Makefile +++ b/test/images/Makefile @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -REGISTRY ?= gcr.io/k8s-e2e-images +REGISTRY ?= gcr.io/kubernetes-e2e-test-images GOARM=7 QEMUVERSION=v2.7.0 GOLANG_VERSION=1.8.3 diff --git a/test/images/clusterapi-tester/NAME b/test/images/clusterapi-tester/NAME deleted file mode 100644 index 97185c48995..00000000000 --- a/test/images/clusterapi-tester/NAME +++ /dev/null @@ -1 +0,0 @@ -clusterapi-tester diff --git a/test/images/clusterapi-tester/VERSION b/test/images/clusterapi-tester/VERSION index 9459d4ba2a0..d3827e75a5c 100644 --- a/test/images/clusterapi-tester/VERSION +++ b/test/images/clusterapi-tester/VERSION @@ -1 +1 @@ -1.1 +1.0 diff --git a/test/images/nvidia-cuda/BASEIMAGE b/test/images/cuda-vector-add/BASEIMAGE similarity index 100% rename from test/images/nvidia-cuda/BASEIMAGE rename to test/images/cuda-vector-add/BASEIMAGE diff --git a/test/images/nvidia-cuda/Dockerfile b/test/images/cuda-vector-add/Dockerfile similarity index 100% rename from test/images/nvidia-cuda/Dockerfile rename to test/images/cuda-vector-add/Dockerfile diff --git a/test/images/nvidia-cuda/README.md b/test/images/cuda-vector-add/README.md similarity index 100% rename from test/images/nvidia-cuda/README.md rename to test/images/cuda-vector-add/README.md diff --git a/test/images/cuda-vector-add/VERSION b/test/images/cuda-vector-add/VERSION new file mode 100644 index 00000000000..d3827e75a5c --- /dev/null +++ b/test/images/cuda-vector-add/VERSION @@ -0,0 +1 @@ +1.0 diff --git a/test/images/dnsutils/NAME b/test/images/dnsutils/NAME deleted file mode 100644 index bca3eb0f23f..00000000000 --- a/test/images/dnsutils/NAME +++ /dev/null @@ -1 +0,0 @@ -dnsutils diff --git a/test/images/dnsutils/VERSION b/test/images/dnsutils/VERSION index 9459d4ba2a0..d3827e75a5c 100644 --- a/test/images/dnsutils/VERSION +++ b/test/images/dnsutils/VERSION @@ -1 +1 @@ -1.1 +1.0 diff --git a/test/images/entrypoint-tester/NAME b/test/images/entrypoint-tester/NAME deleted file mode 100644 index e2d8e243c18..00000000000 --- a/test/images/entrypoint-tester/NAME +++ /dev/null @@ -1 +0,0 @@ -ep diff --git a/test/images/entrypoint-tester/VERSION b/test/images/entrypoint-tester/VERSION index 3b04cfb60da..d3827e75a5c 100644 --- a/test/images/entrypoint-tester/VERSION +++ b/test/images/entrypoint-tester/VERSION @@ -1 +1 @@ -0.2 +1.0 diff --git a/test/images/fakegitserver/NAME b/test/images/fakegitserver/NAME deleted file mode 100644 index 1f1e4b248bf..00000000000 --- a/test/images/fakegitserver/NAME +++ /dev/null @@ -1 +0,0 @@ -fakegitserver diff --git a/test/images/fakegitserver/VERSION b/test/images/fakegitserver/VERSION index 3b04cfb60da..d3827e75a5c 100644 --- a/test/images/fakegitserver/VERSION +++ b/test/images/fakegitserver/VERSION @@ -1 +1 @@ -0.2 +1.0 diff --git a/test/images/goproxy/NAME b/test/images/goproxy/NAME deleted file mode 100644 index 663e1754bde..00000000000 --- a/test/images/goproxy/NAME +++ /dev/null @@ -1 +0,0 @@ -goproxy diff --git a/test/images/goproxy/VERSION b/test/images/goproxy/VERSION index 3b04cfb60da..d3827e75a5c 100644 --- a/test/images/goproxy/VERSION +++ b/test/images/goproxy/VERSION @@ -1 +1 @@ -0.2 +1.0 diff --git a/test/images/hostexec/NAME b/test/images/hostexec/NAME deleted file mode 100644 index 0d7e9c73d9d..00000000000 --- a/test/images/hostexec/NAME +++ /dev/null @@ -1 +0,0 @@ -hostexec diff --git a/test/images/hostexec/VERSION b/test/images/hostexec/VERSION index 7e32cd56983..d3827e75a5c 100644 --- a/test/images/hostexec/VERSION +++ b/test/images/hostexec/VERSION @@ -1 +1 @@ -1.3 +1.0 diff --git a/test/images/image-util.sh b/test/images/image-util.sh index 96ccaddfe4a..d9ff9e31e08 100755 --- a/test/images/image-util.sh +++ b/test/images/image-util.sh @@ -63,8 +63,6 @@ build() { pushd ${temp_dir} # image tag TAG=$(