github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #34145 from lukaszo/revision

Browse Source 
Automatic merge from submit-queue

Fix missleading comment

**What this PR does / why we need it**: It just  fixes misleading comment. It took me some time to figure out real behavior.
This commit is contained in:
Kubernetes Submit Queue 2016-10-12 04:31:02 -07:00 committed by GitHub
commit 1a123f9fc5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/controller/deployment/rollback.go
View File

@ -50,7 +50,8 @@ func (dc *DeploymentController) rollback(deployment *extensions.Deployment, toRe
} }
if v == *toRevision { if v == *toRevision {
glog.V(4).Infof("Found replica set %q with desired revision %d", rs.Name, v) glog.V(4).Infof("Found replica set %q with desired revision %d", rs.Name, v)
// rollback by copying podTemplate.Spec from the replica set, and increment revision number by 1 // rollback by copying podTemplate.Spec from the replica set
// revision number will be incremented during the next getAllReplicaSetsAndSyncRevision call
// no-op if the the spec matches current deployment's podTemplate.Spec // no-op if the the spec matches current deployment's podTemplate.Spec
deployment, performedRollback, err := dc.rollbackToTemplate(deployment, rs) deployment, performedRollback, err := dc.rollbackToTemplate(deployment, rs)
if performedRollback && err == nil { if performedRollback && err == nil {