From 1b4da8f66a4ca5d8052b3cdcc8f2cb97e9b7ffa6 Mon Sep 17 00:00:00 2001 From: Kazuki Suda Date: Thu, 29 Jun 2017 22:12:28 +0900 Subject: [PATCH] Support completions for --clusterrole of kubectl create clusterrolebinding --- pkg/kubectl/cmd/cmd.go | 5 +++++ pkg/kubectl/cmd/create_clusterrolebinding.go | 1 + 2 files changed, 6 insertions(+) diff --git a/pkg/kubectl/cmd/cmd.go b/pkg/kubectl/cmd/cmd.go index 50f442f4ea1..291e40efc54 100644 --- a/pkg/kubectl/cmd/cmd.go +++ b/pkg/kubectl/cmd/cmd.go @@ -130,6 +130,11 @@ __kubectl_get_resource_node() __kubectl_parse_get "node" } +__kubectl_get_resource_clusterrole() +{ + __kubectl_parse_get "clusterrole" +} + # $1 is the name of the pod we want to get the list of containers inside __kubectl_get_containers() { diff --git a/pkg/kubectl/cmd/create_clusterrolebinding.go b/pkg/kubectl/cmd/create_clusterrolebinding.go index d31614be01f..5b7c2729e22 100644 --- a/pkg/kubectl/cmd/create_clusterrolebinding.go +++ b/pkg/kubectl/cmd/create_clusterrolebinding.go @@ -53,6 +53,7 @@ func NewCmdCreateClusterRoleBinding(f cmdutil.Factory, cmdOut io.Writer) *cobra. cmdutil.AddPrinterFlags(cmd) cmdutil.AddGeneratorFlags(cmd, cmdutil.ClusterRoleBindingV1GeneratorName) cmd.Flags().String("clusterrole", "", i18n.T("ClusterRole this ClusterRoleBinding should reference")) + cmd.MarkFlagCustom("clusterrole", "__kubectl_get_resource_clusterrole") cmd.Flags().StringArray("user", []string{}, "Usernames to bind to the role") cmd.Flags().StringArray("group", []string{}, "Groups to bind to the role") cmd.Flags().StringArray("serviceaccount", []string{}, "Service accounts to bind to the role, in the format :")