github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 11:21:47 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #114558 from TommyStarK/unit-tests/pkg-kubelet-nodestatus

Browse Source 
kubelet/nodestatus: Improving test coverage
This commit is contained in:
Kubernetes Prow Robot 2023-03-09 21:34:00 -08:00 committed by GitHub
commit 1b647d5bf8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 114 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

124
pkg/kubelet/nodestatus/setters_test.go
View File

@ -63,16 +63,18 @@ func TestNodeAddress(t *testing.T) {
cloudProviderExternal
cloudProviderNone
)
existingNodeAddress := v1.NodeAddress{Address: "10.1.1.2"}
cases := []struct {
name string
hostnameOverride bool
nodeIP net.IP
cloudProviderType cloudProviderType
nodeAddresses []v1.NodeAddress
expectedAddresses []v1.NodeAddress
existingAnnotations map[string]string
expectedAnnotations map[string]string
shouldError bool
name string
hostnameOverride bool
nodeIP net.IP
cloudProviderType cloudProviderType
nodeAddresses []v1.NodeAddress
expectedAddresses []v1.NodeAddress
existingAnnotations map[string]string
expectedAnnotations map[string]string
shouldError bool
shouldSetNodeAddressBeforeTest bool
}{
{
name: "A single InternalIP",
@ -439,6 +441,15 @@ func TestNodeAddress(t *testing.T) {
},
shouldError: false,
},
{
name: "External cloud provider, node address is already set",
nodeIP: netutils.ParseIPSloppy("10.1.1.1"),
cloudProviderType: cloudProviderExternal,
nodeAddresses: []v1.NodeAddress{existingNodeAddress},
expectedAddresses: []v1.NodeAddress{existingNodeAddress},
shouldError: true,
shouldSetNodeAddressBeforeTest: true,
},
{
name: "No cloud provider does not get nodeIP annotation",
nodeIP: netutils.ParseIPSloppy("10.1.1.1"),
@ -526,6 +537,10 @@ func TestNodeAddress(t *testing.T) {
},
}
if testCase.shouldSetNodeAddressBeforeTest {
existingNode.Status.Addresses = append(existingNode.Status.Addresses, existingNodeAddress)
}
nodeIP := testCase.nodeIP
nodeIPValidator := func(nodeIP net.IP) error {
return nil
@ -579,6 +594,7 @@ func TestNodeAddress_NoCloudProvider(t *testing.T) {
name string
nodeIPs []net.IP
expectedAddresses []v1.NodeAddress
shouldError bool
}{
{
name: "Single --node-ip",
@ -588,6 +604,11 @@ func TestNodeAddress_NoCloudProvider(t *testing.T) {
{Type: v1.NodeHostName, Address: testKubeletHostname},
},
},
{
name: "Invalid single --node-ip (using loopback)",
nodeIPs: []net.IP{netutils.ParseIPSloppy("127.0.0.1")},
shouldError: true,
},
{
name: "Dual --node-ips",
nodeIPs: []net.IP{netutils.ParseIPSloppy("10.1.1.1"), netutils.ParseIPSloppy("fd01::1234")},
@ -597,6 +618,11 @@ func TestNodeAddress_NoCloudProvider(t *testing.T) {
{Type: v1.NodeHostName, Address: testKubeletHostname},
},
},
{
name: "Dual --node-ips but with invalid secondary IP (using multicast IP)",
nodeIPs: []net.IP{netutils.ParseIPSloppy("10.1.1.1"), netutils.ParseIPSloppy("224.0.0.0")},
shouldError: true,
},
}
for _, testCase := range cases {
t.Run(testCase.name, func(t *testing.T) {
@ -611,6 +637,11 @@ func TestNodeAddress_NoCloudProvider(t *testing.T) {
}
nodeIPValidator := func(nodeIP net.IP) error {
if nodeIP.IsLoopback() {
return fmt.Errorf("nodeIP can't be loopback address")
} else if nodeIP.IsMulticast() {
return fmt.Errorf("nodeIP can't be a multicast address")
}
return nil
}
nodeAddressesFunc := func() ([]v1.NodeAddress, error) {
@ -628,7 +659,10 @@ func TestNodeAddress_NoCloudProvider(t *testing.T) {
// call setter on existing node
err := setter(ctx, existingNode)
if err != nil {
if testCase.shouldError && err == nil {
t.Fatal("expected error but no error returned")
}
if err != nil && !testCase.shouldError {
t.Fatalf("unexpected error: %v", err)
}
@ -833,6 +867,37 @@ func TestMachineInfo(t *testing.T) {
},
},
},
{
desc: "hugepages reservation greater than node memory capacity should result in memory capacity set to 0",
node: &v1.Node{
Status: v1.NodeStatus{
Capacity: v1.ResourceList{
v1.ResourceHugePagesPrefix + "test": *resource.NewQuantity(1025, resource.BinarySI),
},
},
},
maxPods: 110,
machineInfo: &cadvisorapiv1.MachineInfo{
NumCores: 2,
MemoryCapacity: 1024,
},
expectNode: &v1.Node{
Status: v1.NodeStatus{
Capacity: v1.ResourceList{
v1.ResourceCPU: *resource.NewMilliQuantity(2000, resource.DecimalSI),
v1.ResourceMemory: *resource.NewQuantity(1024, resource.BinarySI),
v1.ResourcePods: *resource.NewQuantity(110, resource.DecimalSI),
v1.ResourceHugePagesPrefix + "test": *resource.NewQuantity(1025, resource.BinarySI),
},
Allocatable: v1.ResourceList{
v1.ResourceCPU: *resource.NewMilliQuantity(2000, resource.DecimalSI),
v1.ResourceMemory: *resource.NewQuantity(0, resource.BinarySI),
v1.ResourcePods: *resource.NewQuantity(110, resource.DecimalSI),
v1.ResourceHugePagesPrefix + "test": *resource.NewQuantity(1025, resource.BinarySI),
},
},
},
},
{
desc: "ephemeral storage is reflected in capacity and allocatable",
node: &v1.Node{},
@ -1937,6 +2002,45 @@ func TestVolumeLimits(t *testing.T) {
}
}
func TestDaemonEndpoints(t *testing.T) {
for _, test := range []struct {
name string
endpoints *v1.NodeDaemonEndpoints
expected *v1.NodeDaemonEndpoints
}{
{
name: "empty daemon endpoints",
endpoints: &v1.NodeDaemonEndpoints{},
expected: &v1.NodeDaemonEndpoints{KubeletEndpoint: v1.DaemonEndpoint{Port: 0}},
},
{
name: "daemon endpoints with specific port",
endpoints: &v1.NodeDaemonEndpoints{KubeletEndpoint: v1.DaemonEndpoint{Port: 5678}},
expected: &v1.NodeDaemonEndpoints{KubeletEndpoint: v1.DaemonEndpoint{Port: 5678}},
},
} {
t.Run(test.name, func(t *testing.T) {
ctx := context.Background()
existingNode := &v1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: testKubeletHostname,
},
Spec: v1.NodeSpec{},
Status: v1.NodeStatus{
Addresses: []v1.NodeAddress{},
},
}
setter := DaemonEndpoints(test.endpoints)
if err := setter(ctx, existingNode); err != nil {
t.Fatal(err)
}
assert.Equal(t, *test.expected, existingNode.Status.DaemonEndpoints)
})
}
}
// Test Helpers:
// testEvent is used to record events for tests