mirror of
https://github.com/k3s-io/kubernetes.git
synced 2026-01-05 15:37:24 +00:00
Rename controller pkg/registry/core/controller to pkg/registry/core/replicationcontroller
This commit is contained in:
Rene Saenz
217
pkg/registry/core/replicationcontroller/strategy_test.go
Normal file
217
pkg/registry/core/replicationcontroller/strategy_test.go
Normal file
@@ -0,0 +1,217 @@
|
||||
/*
|
||||
Copyright 2015 The Kubernetes Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package replicationcontroller
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
||||
genericapirequest "k8s.io/apiserver/pkg/endpoints/request"
|
||||
"k8s.io/kubernetes/pkg/api"
|
||||
apitesting "k8s.io/kubernetes/pkg/api/testing"
|
||||
)
|
||||
|
||||
func TestControllerStrategy(t *testing.T) {
|
||||
ctx := genericapirequest.NewDefaultContext()
|
||||
if !Strategy.NamespaceScoped() {
|
||||
t.Errorf("ReplicationController must be namespace scoped")
|
||||
}
|
||||
if Strategy.AllowCreateOnUpdate() {
|
||||
t.Errorf("ReplicationController should not allow create on update")
|
||||
}
|
||||
|
||||
validSelector := map[string]string{"a": "b"}
|
||||
validPodTemplate := api.PodTemplate{
|
||||
Template: api.PodTemplateSpec{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Labels: validSelector,
|
||||
},
|
||||
Spec: api.PodSpec{
|
||||
RestartPolicy: api.RestartPolicyAlways,
|
||||
DNSPolicy: api.DNSClusterFirst,
|
||||
Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: api.TerminationMessageReadFile}},
|
||||
},
|
||||
},
|
||||
}
|
||||
rc := &api.ReplicationController{
|
||||
ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault},
|
||||
Spec: api.ReplicationControllerSpec{
|
||||
Selector: validSelector,
|
||||
Template: &validPodTemplate.Template,
|
||||
},
|
||||
Status: api.ReplicationControllerStatus{
|
||||
Replicas: 1,
|
||||
ObservedGeneration: int64(10),
|
||||
},
|
||||
}
|
||||
|
||||
Strategy.PrepareForCreate(ctx, rc)
|
||||
if rc.Status.Replicas != 0 {
|
||||
t.Error("ReplicationController should not allow setting status.replicas on create")
|
||||
}
|
||||
if rc.Status.ObservedGeneration != int64(0) {
|
||||
t.Error("ReplicationController should not allow setting status.observedGeneration on create")
|
||||
}
|
||||
errs := Strategy.Validate(ctx, rc)
|
||||
if len(errs) != 0 {
|
||||
t.Errorf("Unexpected error validating %v", errs)
|
||||
}
|
||||
|
||||
invalidRc := &api.ReplicationController{
|
||||
ObjectMeta: metav1.ObjectMeta{Name: "bar", ResourceVersion: "4"},
|
||||
}
|
||||
Strategy.PrepareForUpdate(ctx, invalidRc, rc)
|
||||
errs = Strategy.ValidateUpdate(ctx, invalidRc, rc)
|
||||
if len(errs) == 0 {
|
||||
t.Errorf("Expected a validation error")
|
||||
}
|
||||
if invalidRc.ResourceVersion != "4" {
|
||||
t.Errorf("Incoming resource version on update should not be mutated")
|
||||
}
|
||||
}
|
||||
|
||||
func TestControllerStatusStrategy(t *testing.T) {
|
||||
ctx := genericapirequest.NewDefaultContext()
|
||||
if !StatusStrategy.NamespaceScoped() {
|
||||
t.Errorf("ReplicationController must be namespace scoped")
|
||||
}
|
||||
if StatusStrategy.AllowCreateOnUpdate() {
|
||||
t.Errorf("ReplicationController should not allow create on update")
|
||||
}
|
||||
validSelector := map[string]string{"a": "b"}
|
||||
validPodTemplate := api.PodTemplate{
|
||||
Template: api.PodTemplateSpec{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Labels: validSelector,
|
||||
},
|
||||
Spec: api.PodSpec{
|
||||
RestartPolicy: api.RestartPolicyAlways,
|
||||
DNSPolicy: api.DNSClusterFirst,
|
||||
Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: "File"}},
|
||||
},
|
||||
},
|
||||
}
|
||||
oldController := &api.ReplicationController{
|
||||
ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault, ResourceVersion: "10"},
|
||||
Spec: api.ReplicationControllerSpec{
|
||||
Replicas: 3,
|
||||
Selector: validSelector,
|
||||
Template: &validPodTemplate.Template,
|
||||
},
|
||||
Status: api.ReplicationControllerStatus{
|
||||
Replicas: 1,
|
||||
ObservedGeneration: int64(10),
|
||||
},
|
||||
}
|
||||
newController := &api.ReplicationController{
|
||||
ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: metav1.NamespaceDefault, ResourceVersion: "9"},
|
||||
Spec: api.ReplicationControllerSpec{
|
||||
Replicas: 1,
|
||||
Selector: validSelector,
|
||||
Template: &validPodTemplate.Template,
|
||||
},
|
||||
Status: api.ReplicationControllerStatus{
|
||||
Replicas: 3,
|
||||
ObservedGeneration: int64(11),
|
||||
},
|
||||
}
|
||||
StatusStrategy.PrepareForUpdate(ctx, newController, oldController)
|
||||
if newController.Status.Replicas != 3 {
|
||||
t.Errorf("Replication controller status updates should allow change of replicas: %v", newController.Status.Replicas)
|
||||
}
|
||||
if newController.Spec.Replicas != 3 {
|
||||
t.Errorf("PrepareForUpdate should have preferred spec")
|
||||
}
|
||||
errs := StatusStrategy.ValidateUpdate(ctx, newController, oldController)
|
||||
if len(errs) != 0 {
|
||||
t.Errorf("Unexpected error %v", errs)
|
||||
}
|
||||
}
|
||||
|
||||
func TestSelectableFieldLabelConversions(t *testing.T) {
|
||||
apitesting.TestSelectableFieldLabelConversionsOfKind(t,
|
||||
api.Registry.GroupOrDie(api.GroupName).GroupVersion.String(),
|
||||
"ReplicationController",
|
||||
ControllerToSelectableFields(&api.ReplicationController{}),
|
||||
nil,
|
||||
)
|
||||
}
|
||||
|
||||
func TestValidateUpdate(t *testing.T) {
|
||||
ctx := genericapirequest.NewDefaultContext()
|
||||
validSelector := map[string]string{"a": "b"}
|
||||
validPodTemplate := api.PodTemplate{
|
||||
Template: api.PodTemplateSpec{
|
||||
ObjectMeta: metav1.ObjectMeta{
|
||||
Labels: validSelector,
|
||||
},
|
||||
Spec: api.PodSpec{
|
||||
RestartPolicy: api.RestartPolicyAlways,
|
||||
DNSPolicy: api.DNSClusterFirst,
|
||||
Containers: []api.Container{{Name: "abc", Image: "image", ImagePullPolicy: "IfNotPresent", TerminationMessagePolicy: "File"}},
|
||||
},
|
||||
},
|
||||
}
|
||||
oldController := &api.ReplicationController{
|
||||
ObjectMeta: metav1.ObjectMeta{Name: "abc", Namespace: api.NamespaceDefault, ResourceVersion: "10", Annotations: make(map[string]string)},
|
||||
Spec: api.ReplicationControllerSpec{
|
||||
Replicas: 3,
|
||||
Selector: validSelector,
|
||||
Template: &validPodTemplate.Template,
|
||||
},
|
||||
Status: api.ReplicationControllerStatus{
|
||||
Replicas: 1,
|
||||
ObservedGeneration: int64(10),
|
||||
},
|
||||
}
|
||||
// Conversion sets this annotation
|
||||
oldController.Annotations[api.NonConvertibleAnnotationPrefix+"/"+"spec.selector"] = "no way"
|
||||
|
||||
// Deep-copy so we won't mutate both selectors.
|
||||
objCopy, err := api.Scheme.DeepCopy(oldController)
|
||||
if err != nil {
|
||||
t.Fatalf("unexpected deep-copy error: %v", err)
|
||||
}
|
||||
newController, ok := objCopy.(*api.ReplicationController)
|
||||
if !ok {
|
||||
t.Fatalf("unexpected object: %#v", objCopy)
|
||||
}
|
||||
// Irrelevant (to the selector) update for the replication controller.
|
||||
newController.Spec.Replicas = 5
|
||||
|
||||
// If they didn't try to update the selector then we should not return any error.
|
||||
errs := Strategy.ValidateUpdate(ctx, newController, oldController)
|
||||
if len(errs) > 0 {
|
||||
t.Fatalf("unexpected errors: %v", errs)
|
||||
}
|
||||
|
||||
// Update the selector - validation should return an error.
|
||||
newController.Spec.Selector["shiny"] = "newlabel"
|
||||
newController.Spec.Template.Labels["shiny"] = "newlabel"
|
||||
|
||||
errs = Strategy.ValidateUpdate(ctx, newController, oldController)
|
||||
for _, err := range errs {
|
||||
t.Logf("%#v\n", err)
|
||||
}
|
||||
if len(errs) != 1 {
|
||||
t.Fatalf("expected a validation error")
|
||||
}
|
||||
if !strings.Contains(errs[0].Error(), "selector") {
|
||||
t.Fatalf("expected error related to the selector")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user