From 1c66b708ec5e7dcc50735e111d96366c869a9397 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Fri, 16 Dec 2022 10:31:21 +0100 Subject: [PATCH] ginkgo-e2e.sh: remove deprecated --slow-spec-threshold From the warning message that ginkgo now emits: --slow-spec-threshold is deprecated --slow-spec-threshold has been deprecated and will be removed in a future version of Ginkgo. This feature has proved to be more noisy than useful. You can use --poll-progress-after, instead, to get more actionable feedback about potentially slow specs and understand where they might be getting stuck. We already use --poll-progress-after. --- hack/ginkgo-e2e.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/hack/ginkgo-e2e.sh b/hack/ginkgo-e2e.sh index 409ff5892cd..b66843c68a9 100755 --- a/hack/ginkgo-e2e.sh +++ b/hack/ginkgo-e2e.sh @@ -134,7 +134,6 @@ fi # Some arguments (like --nodes) are only supported when using the CLI. # Those get set below when choosing the program. ginkgo_args=( - "--slow-spec-threshold=${GINKGO_SLOW_SPEC_THRESHOLD:-300s}" "--poll-progress-after=${GINKGO_POLL_PROGRESS_AFTER:-300s}" "--poll-progress-interval=${GINKGO_POLL_PROGRESS_INTERVAL:-20s}" "--source-root=${KUBE_ROOT}"