github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 11:50:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #64938 from brendandburns/todo2

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 64895, 64938, 63700, 65050, 64957). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove an old TODO.

The ImagePullPolicy is immediately overwritten by the call to `updatePodSpec` below the initialization, so it's not needed where it is.
This commit is contained in:
Kubernetes Submit Queue 2018-06-21 04:15:08 -07:00 committed by GitHub
commit 1cbb61f8a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/kubectl/run.go
View File

@ -877,8 +877,6 @@ func (BasicPod) Generate(genericParams map[string]interface{}) (runtime.Object,
if len(restartPolicy) == 0 { if len(restartPolicy) == 0 {
restartPolicy = v1.RestartPolicyAlways restartPolicy = v1.RestartPolicyAlways
} }
// TODO: Figure out why we set ImagePullPolicy here, whether we can make it
// consistent with the other places imagePullPolicy is set using flag.
pod := v1.Pod{ pod := v1.Pod{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{
Name: name, Name: name,
@ -888,13 +886,12 @@ func (BasicPod) Generate(genericParams map[string]interface{}) (runtime.Object,
ServiceAccountName: params["serviceaccount"], ServiceAccountName: params["serviceaccount"],
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: name, Name: name,
Image: params["image"], Image: params["image"],
ImagePullPolicy: v1.PullIfNotPresent, Stdin: stdin,
Stdin: stdin, StdinOnce: !leaveStdinOpen && stdin,
StdinOnce: !leaveStdinOpen && stdin, TTY: tty,
TTY: tty, Resources: resourceRequirements,
Resources: resourceRequirements,
}, },
}, },
DNSPolicy: v1.DNSClusterFirst, DNSPolicy: v1.DNSClusterFirst,

38
pkg/kubectl/run_test.go
View File

@ -442,9 +442,8 @@ func TestGeneratePod(t *testing.T) {
Spec: v1.PodSpec{ Spec: v1.PodSpec{
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: "foo", Name: "foo",
Image: "someimage", Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
}, },
}, },
DNSPolicy: v1.DNSClusterFirst, DNSPolicy: v1.DNSClusterFirst,
@ -514,9 +513,8 @@ func TestGeneratePod(t *testing.T) {
Spec: v1.PodSpec{ Spec: v1.PodSpec{
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: "foo", Name: "foo",
Image: "someimage", Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
Ports: []v1.ContainerPort{ Ports: []v1.ContainerPort{
{ {
ContainerPort: 80, ContainerPort: 80,
@ -545,9 +543,8 @@ func TestGeneratePod(t *testing.T) {
Spec: v1.PodSpec{ Spec: v1.PodSpec{
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: "foo", Name: "foo",
Image: "someimage", Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
Ports: []v1.ContainerPort{ Ports: []v1.ContainerPort{
{ {
ContainerPort: 80, ContainerPort: 80,
@ -587,9 +584,8 @@ func TestGeneratePod(t *testing.T) {
Spec: v1.PodSpec{ Spec: v1.PodSpec{
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: "foo", Name: "foo",
Image: "someimage", Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent,
}, },
}, },
DNSPolicy: v1.DNSClusterFirst, DNSPolicy: v1.DNSClusterFirst,
@ -614,11 +610,10 @@ func TestGeneratePod(t *testing.T) {
Spec: v1.PodSpec{ Spec: v1.PodSpec{
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: "foo", Name: "foo",
Image: "someimage", Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent, Stdin: true,
Stdin: true, StdinOnce: true,
StdinOnce: true,
}, },
}, },
DNSPolicy: v1.DNSClusterFirst, DNSPolicy: v1.DNSClusterFirst,
@ -644,11 +639,10 @@ func TestGeneratePod(t *testing.T) {
Spec: v1.PodSpec{ Spec: v1.PodSpec{
Containers: []v1.Container{ Containers: []v1.Container{
{ {
Name: "foo", Name: "foo",
Image: "someimage", Image: "someimage",
ImagePullPolicy: v1.PullIfNotPresent, Stdin: true,
Stdin: true, StdinOnce: false,
StdinOnce: false,
}, },
}, },
DNSPolicy: v1.DNSClusterFirst, DNSPolicy: v1.DNSClusterFirst,