From 8150cf8d96035c789068778e42568887de777063 Mon Sep 17 00:00:00 2001 From: Fabio Bertinatto Date: Mon, 21 Feb 2022 14:28:15 -0300 Subject: [PATCH] Update EnableControllerAttachDetach documentation The kubelet does not support attach/detach operations on CSI volumes. As a result, CSI volumes rely on the Attach/Detach controller enabled. --- pkg/generated/openapi/zz_generated.openapi.go | 2 +- staging/src/k8s.io/kubelet/config/v1beta1/types.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/generated/openapi/zz_generated.openapi.go b/pkg/generated/openapi/zz_generated.openapi.go index 6bf9a2294df..0cfcc96cb41 100644 --- a/pkg/generated/openapi/zz_generated.openapi.go +++ b/pkg/generated/openapi/zz_generated.openapi.go @@ -53191,7 +53191,7 @@ func schema_k8sio_kubelet_config_v1beta1_KubeletConfiguration(ref common.Referen }, "enableControllerAttachDetach": { SchemaProps: spec.SchemaProps{ - Description: "enableControllerAttachDetach enables the Attach/Detach controller to manage attachment/detachment of volumes scheduled to this node, and disables kubelet from executing any attach/detach operations. Default: true", + Description: "enableControllerAttachDetach enables the Attach/Detach controller to manage attachment/detachment of volumes scheduled to this node, and disables kubelet from executing any attach/detach operations. Note: attaching/detaching CSI volumes is not supported by the kubelet, so this option needs to be true for that use case. Default: true", Type: []string{"boolean"}, Format: "", }, diff --git a/staging/src/k8s.io/kubelet/config/v1beta1/types.go b/staging/src/k8s.io/kubelet/config/v1beta1/types.go index 41de36af341..ef3f33ca644 100644 --- a/staging/src/k8s.io/kubelet/config/v1beta1/types.go +++ b/staging/src/k8s.io/kubelet/config/v1beta1/types.go @@ -525,6 +525,8 @@ type KubeletConfiguration struct { // enableControllerAttachDetach enables the Attach/Detach controller to // manage attachment/detachment of volumes scheduled to this node, and // disables kubelet from executing any attach/detach operations. + // Note: attaching/detaching CSI volumes is not supported by the kubelet, + // so this option needs to be true for that use case. // Default: true // +optional EnableControllerAttachDetach *bool `json:"enableControllerAttachDetach,omitempty"`