From 1d1a5499e717b928c6b2782fdcad9fa4052a38a1 Mon Sep 17 00:00:00 2001 From: Sean Sullivan Date: Thu, 30 Sep 2021 13:53:00 -0700 Subject: [PATCH] Fixes kubectl command headers which hangs on kubectl run --- staging/src/k8s.io/kubectl/pkg/cmd/cmd.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/cmd.go b/staging/src/k8s.io/kubectl/pkg/cmd/cmd.go index fcdc8574bc3..f7edf8a7484 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/cmd.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/cmd.go @@ -425,8 +425,12 @@ func addCmdHeaderHooks(cmds *cobra.Command, kubeConfigFlags *genericclioptions.C // Wraps CommandHeaderRoundTripper around standard RoundTripper. kubeConfigFlags.WrapConfigFn = func(c *rest.Config) *rest.Config { c.Wrap(func(rt http.RoundTripper) http.RoundTripper { - crt.Delegate = rt - return crt + // Must be separate RoundTripper; not "crt" closure. + // Fixes: https://github.com/kubernetes/kubectl/issues/1098 + return &genericclioptions.CommandHeaderRoundTripper{ + Delegate: rt, + Headers: crt.Headers, + } }) return c }