From 6d001ebb68efd8a499c07b37b9b59158ca6159c8 Mon Sep 17 00:00:00 2001 From: brianpursley Date: Tue, 25 Aug 2020 20:37:49 -0400 Subject: [PATCH] Add logging if container or pod fails to be killed --- pkg/kubelet/kubelet.go | 2 ++ pkg/kubelet/kuberuntime/kuberuntime_container.go | 1 + 2 files changed, 3 insertions(+) diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index b75a9a094b0..74e6158fdec 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -1524,6 +1524,8 @@ func (kl *Kubelet) syncPod(o syncPodOptions) error { if !pcm.Exists(pod) && !firstSync { if err := kl.killPod(pod, nil, podStatus, nil); err == nil { podKilled = true + } else { + klog.Errorf("killPod for pod %q (podStatus=%v) failed: %v", format.Pod(pod), podStatus, err) } } // Create and Update pod's Cgroups diff --git a/pkg/kubelet/kuberuntime/kuberuntime_container.go b/pkg/kubelet/kuberuntime/kuberuntime_container.go index ec8d9fac03f..4cee811ce89 100644 --- a/pkg/kubelet/kuberuntime/kuberuntime_container.go +++ b/pkg/kubelet/kuberuntime/kuberuntime_container.go @@ -658,6 +658,7 @@ func (m *kubeGenericRuntimeManager) killContainersWithSyncResult(pod *v1.Pod, ru killContainerResult := kubecontainer.NewSyncResult(kubecontainer.KillContainer, container.Name) if err := m.killContainer(pod, container.ID, container.Name, "", gracePeriodOverride); err != nil { killContainerResult.Fail(kubecontainer.ErrKillContainer, err.Error()) + klog.Errorf("killContainer %q(id=%q) for pod %q failed: %v", container.Name, container.ID, format.Pod(pod), err) } containerResults <- killContainerResult }(container)