Fix incorrect test code in pkg/volume/csi/csi_attacher_test.go file

This commit is contained in:
mengjiao.liu 2021-04-01 15:18:07 +08:00
parent a651804427
commit 1d764952da

View File

@ -754,7 +754,7 @@ func TestAttacherWaitForVolumeAttachment(t *testing.T) {
if tc.shouldFail && err == nil { if tc.shouldFail && err == nil {
t.Error("expecting failure, but err is nil") t.Error("expecting failure, but err is nil")
} }
if tc.initAttachErr != nil { if tc.initAttachErr != nil && err != nil {
if tc.initAttachErr.Message != err.Error() { if tc.initAttachErr.Message != err.Error() {
t.Errorf("expecting error [%v], got [%v]", tc.initAttachErr.Message, err.Error()) t.Errorf("expecting error [%v], got [%v]", tc.initAttachErr.Message, err.Error())
} }
@ -1268,7 +1268,7 @@ func TestAttacherMountDevice(t *testing.T) {
} }
return return
} }
if err == nil && tc.shouldFail { if tc.shouldFail {
t.Errorf("test should fail, but no error occurred") t.Errorf("test should fail, but no error occurred")
} }
@ -1440,7 +1440,7 @@ func TestAttacherMountDeviceWithInline(t *testing.T) {
} }
return return
} }
if err == nil && tc.shouldFail { if tc.shouldFail {
t.Errorf("test should fail, but no error occurred") t.Errorf("test should fail, but no error occurred")
} }
@ -1585,7 +1585,7 @@ func TestAttacherUnmountDevice(t *testing.T) {
} }
return return
} }
if err == nil && tc.shouldFail { if tc.shouldFail {
t.Errorf("test should fail, but no error occurred") t.Errorf("test should fail, but no error occurred")
} }