From 1daf1b0705fd2dabba59f3c24fe0ee363bb5c6f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Filip=20K=C5=99epinsk=C3=BD?= Date: Mon, 30 Oct 2023 14:35:02 +0100 Subject: [PATCH] test that controller descriptors should not be feature gated controllers enabled by default should define feature gates in ControllerDescriptor.requiredFeatureGates and not during a descriptor registration in NewControllerDescriptors --- cmd/kube-controller-manager/app/controllermanager_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmd/kube-controller-manager/app/controllermanager_test.go b/cmd/kube-controller-manager/app/controllermanager_test.go index d3adbebb88d..efde618dc1c 100644 --- a/cmd/kube-controller-manager/app/controllermanager_test.go +++ b/cmd/kube-controller-manager/app/controllermanager_test.go @@ -107,6 +107,9 @@ func TestNewControllerDescriptorsShouldNotPanic(t *testing.T) { } func TestNewControllerDescriptorsAlwaysReturnsDescriptorsForAllControllers(t *testing.T) { + defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllAlpha", false)() + defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllBeta", false)() + controllersWithoutFeatureGates := KnownControllers() defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, "AllAlpha", true)()