From 526b4b4ce226349b1e0587db14d1321d0b27bbff Mon Sep 17 00:00:00 2001 From: Dipankar Das Date: Sat, 7 Jan 2023 15:45:45 +0530 Subject: [PATCH 1/2] Added fatalf for error handling Signed-off-by: Dipankar Das --- .../plugin/validatingadmissionpolicy/admission_test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go b/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go index 684a4659b7e..314e119fe6a 100644 --- a/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go +++ b/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go @@ -252,13 +252,11 @@ func setupTestCommon(t *testing.T, compiler ValidatorCompiler, shouldStartInform features.ValidatingAdmissionPolicy: { Default: true, PreRelease: featuregate.Alpha}}) if err != nil { - // FIXME: handle error. - panic("Unexpected error") + t.Fatalf("Unable to add featureGate with Release as Alpha") } err = featureGate.SetFromMap(map[string]bool{string(features.ValidatingAdmissionPolicy): true}) if err != nil { - // FIXME: handle error. - panic("Unexpected error.") + t.Fatalf("Unable to Set key ValidateAdmissionPolicy to the Alpha featureGate") } plug, err := NewPlugin() From 50bc46bd8fdc687811b3e4bba6a3d8d0706c8d59 Mon Sep 17 00:00:00 2001 From: Dipankar Das Date: Wed, 11 Jan 2023 08:08:25 +0530 Subject: [PATCH 2/2] changes to the fatal message generated Signed-off-by: Dipankar Das --- .../plugin/validatingadmissionpolicy/admission_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go b/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go index 314e119fe6a..a95623fc563 100644 --- a/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go +++ b/staging/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/admission_test.go @@ -252,11 +252,11 @@ func setupTestCommon(t *testing.T, compiler ValidatorCompiler, shouldStartInform features.ValidatingAdmissionPolicy: { Default: true, PreRelease: featuregate.Alpha}}) if err != nil { - t.Fatalf("Unable to add featureGate with Release as Alpha") + t.Fatalf("Unable to add feature gate: %v", err) } err = featureGate.SetFromMap(map[string]bool{string(features.ValidatingAdmissionPolicy): true}) if err != nil { - t.Fatalf("Unable to Set key ValidateAdmissionPolicy to the Alpha featureGate") + t.Fatalf("Unable to store flag gate: %v", err) } plug, err := NewPlugin()