From 1e3ec2b639d8dfffe6ecdfa8775d4558f7f4c174 Mon Sep 17 00:00:00 2001 From: Jingtao Ren Date: Fri, 17 Nov 2017 09:33:05 -0800 Subject: [PATCH] correct doc for reconcileSecurityGroup --- pkg/cloudprovider/providers/azure/azure_loadbalancer.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/azure/azure_loadbalancer.md b/pkg/cloudprovider/providers/azure/azure_loadbalancer.md index 05a560b75b7..141d066cf15 100644 --- a/pkg/cloudprovider/providers/azure/azure_loadbalancer.md +++ b/pkg/cloudprovider/providers/azure/azure_loadbalancer.md @@ -22,8 +22,10 @@ Service Annotation for Auto and specific load balancer mode - Call az cloud to CreateOrUpdate on this lb, or Delete if nothing left - return lb, err -- reconcileSecurityGroup(clusterName string, service *v1.Service, lbStatus *v1.LoadBalancerStatus, wantLb bool) (*network.SecurityGroup, error) +- reconcileSecurityGroup(clusterName string, service *v1.Service, lbIP *string, wantLb bool) (*network.SecurityGroup, error) - Go though NSG' properties, update based on wantLb + - Use destinationIPAddress as target address if possible + - Consolidate NSG rules if possible - If any change on the NSG, (the NSG should always exists) - Call az cloud to CreateOrUpdate on this NSG - return sg, err