From 1f235c858c39f77161d5b5e8272a7113bfca3143 Mon Sep 17 00:00:00 2001 From: knight42 Date: Fri, 4 Sep 2020 23:35:53 +0800 Subject: [PATCH] test(apiserver): deflake TestClientReceivedGOAWAY protect `localAddr` from concurrent read and write Signed-off-by: knight42 --- .../src/k8s.io/apiserver/pkg/server/filters/goaway_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/staging/src/k8s.io/apiserver/pkg/server/filters/goaway_test.go b/staging/src/k8s.io/apiserver/pkg/server/filters/goaway_test.go index 3b4aba993be..afdc99ac8a5 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/filters/goaway_test.go +++ b/staging/src/k8s.io/apiserver/pkg/server/filters/goaway_test.go @@ -342,6 +342,7 @@ func TestClientReceivedGOAWAY(t *testing.T) { for _, tc := range cases { t.Run(tc.name, func(t *testing.T) { + var mu sync.Mutex // localAddr indicates how many TCP connection set up localAddr := make([]string, 0) @@ -350,7 +351,10 @@ func TestClientReceivedGOAWAY(t *testing.T) { if err != nil { t.Fatalf("unexpect connection err: %v", err) } + + mu.Lock() localAddr = append(localAddr, conn.LocalAddr().String()) + mu.Unlock() return }) if err != nil {