From 1f9704c713a1c1b3703603f7dbcdb049791da708 Mon Sep 17 00:00:00 2001 From: Joakim Roubert Date: Fri, 24 Apr 2020 10:22:50 +0200 Subject: [PATCH] Code review update Change-Id: I384a73efe995c529fb4b3636cb9639eafb90787f Signed-off-by: Joakim Roubert --- cluster/gce/gci/configure-helper.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cluster/gce/gci/configure-helper.sh b/cluster/gce/gci/configure-helper.sh index dfe94d262a1..590b5f11bbc 100644 --- a/cluster/gce/gci/configure-helper.sh +++ b/cluster/gce/gci/configure-helper.sh @@ -253,9 +253,7 @@ function get-or-generate-uuid(){ else # generate new uuid and add it to the map local myuuid - myuuid=$(uuidgen) - # shellcheck disable=SC2181 - if [[ $? -ne 0 ]]; then + if ! myuuid=$(uuidgen); then echo "Failed to generate valid UUID with uuidgen" >&2 exit 2 fi