mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-06 18:54:06 +00:00
Merge pull request #92129 from weijiehu/azure_controller_vmss
Improves unittest CC for azure_controller_vmss
This commit is contained in:
Kubernetes Prow Robot
GitHub
commit
1fa20301a0
@ -114,6 +114,7 @@ go_test(
|
|||||||
"azure_config_test.go",
|
"azure_config_test.go",
|
||||||
"azure_controller_common_test.go",
|
"azure_controller_common_test.go",
|
||||||
"azure_controller_standard_test.go",
|
"azure_controller_standard_test.go",
|
||||||
|
"azure_controller_vmss_test.go",
|
||||||
"azure_instances_test.go",
|
"azure_instances_test.go",
|
||||||
"azure_loadbalancer_test.go",
|
"azure_loadbalancer_test.go",
|
||||||
"azure_ratelimit_test.go",
|
"azure_ratelimit_test.go",
|
||||||
|
|||||||
@ -0,0 +1,322 @@
|
|||||||
|
// +build !providerless
|
||||||
|
|
||||||
|
/*
|
||||||
|
Copyright 2020 The Kubernetes Authors.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package azure
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"net/http"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2019-12-01/compute"
|
||||||
|
"github.com/Azure/go-autorest/autorest/to"
|
||||||
|
"github.com/golang/mock/gomock"
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
|
||||||
|
"k8s.io/apimachinery/pkg/types"
|
||||||
|
cloudprovider "k8s.io/cloud-provider"
|
||||||
|
azcache "k8s.io/legacy-cloud-providers/azure/cache"
|
||||||
|
"k8s.io/legacy-cloud-providers/azure/clients/vmssclient/mockvmssclient"
|
||||||
|
"k8s.io/legacy-cloud-providers/azure/clients/vmssvmclient/mockvmssvmclient"
|
||||||
|
"k8s.io/legacy-cloud-providers/azure/retry"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestAttachDiskWithVMSS(t *testing.T) {
|
||||||
|
ctrl := gomock.NewController(t)
|
||||||
|
defer ctrl.Finish()
|
||||||
|
|
||||||
|
fakeStatusNotFoundVMSSName := types.NodeName("FakeStatusNotFoundVMSSName")
|
||||||
|
testCases := []struct {
|
||||||
|
desc string
|
||||||
|
vmList map[string]string
|
||||||
|
vmssVMList []string
|
||||||
|
vmssName types.NodeName
|
||||||
|
vmssvmName types.NodeName
|
||||||
|
isManagedDisk bool
|
||||||
|
existedDisk compute.Disk
|
||||||
|
expectedErr bool
|
||||||
|
expectedErrMsg error
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
desc: "an error shall be returned if it is invalid vmss name",
|
||||||
|
vmssVMList: []string{"vmss-vm-000001"},
|
||||||
|
vmssName: "vm1",
|
||||||
|
vmssvmName: "vm1",
|
||||||
|
isManagedDisk: false,
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: true,
|
||||||
|
expectedErrMsg: fmt.Errorf("not a vmss instance"),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "no error shall be returned if everything is good with managed disk",
|
||||||
|
vmssVMList: []string{"vmss00-vm-000000", "vmss00-vm-000001", "vmss00-vm-000002"},
|
||||||
|
vmssName: "vmss00",
|
||||||
|
vmssvmName: "vmss00-vm-000000",
|
||||||
|
isManagedDisk: true,
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "no error shall be returned if everything is good with non-managed disk",
|
||||||
|
vmssVMList: []string{"vmss00-vm-000000", "vmss00-vm-000001", "vmss00-vm-000002"},
|
||||||
|
vmssName: "vmss00",
|
||||||
|
vmssvmName: "vmss00-vm-000000",
|
||||||
|
isManagedDisk: false,
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "an error shall be returned if response StatusNotFound",
|
||||||
|
vmssVMList: []string{"vmss00-vm-000000", "vmss00-vm-000001", "vmss00-vm-000002"},
|
||||||
|
vmssName: fakeStatusNotFoundVMSSName,
|
||||||
|
vmssvmName: "vmss00-vm-000000",
|
||||||
|
isManagedDisk: false,
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: true,
|
||||||
|
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 404, RawError: instance not found"),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for i, test := range testCases {
|
||||||
|
scaleSetName := string(test.vmssName)
|
||||||
|
ss, err := newTestScaleSet(ctrl)
|
||||||
|
assert.NoError(t, err, test.desc)
|
||||||
|
testCloud := ss.cloud
|
||||||
|
testCloud.PrimaryScaleSetName = scaleSetName
|
||||||
|
expectedVMSS := buildTestVMSS(scaleSetName, []string{testLBBackendpoolID0})
|
||||||
|
mockVMSSClient := testCloud.VirtualMachineScaleSetsClient.(*mockvmssclient.MockInterface)
|
||||||
|
mockVMSSClient.EXPECT().List(gomock.Any(), testCloud.ResourceGroup).Return([]compute.VirtualMachineScaleSet{expectedVMSS}, nil).AnyTimes()
|
||||||
|
mockVMSSClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, scaleSetName).Return(expectedVMSS, nil).MaxTimes(1)
|
||||||
|
mockVMSSClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any()).Return(nil).MaxTimes(1)
|
||||||
|
|
||||||
|
expectedVMSSVMs, _, _ := buildTestVirtualMachineEnv(testCloud, scaleSetName, "", 0, test.vmssVMList, "succeeded")
|
||||||
|
for _, vmssvm := range expectedVMSSVMs {
|
||||||
|
vmssvm.StorageProfile = &compute.StorageProfile{
|
||||||
|
OsDisk: &compute.OSDisk{
|
||||||
|
Name: to.StringPtr("osdisk1"),
|
||||||
|
ManagedDisk: &compute.ManagedDiskParameters{
|
||||||
|
ID: to.StringPtr("ManagedID"),
|
||||||
|
DiskEncryptionSet: &compute.DiskEncryptionSetParameters{
|
||||||
|
ID: to.StringPtr("DiskEncryptionSetID"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
DataDisks: &[]compute.DataDisk{},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
mockVMSSVMClient := testCloud.VirtualMachineScaleSetVMsClient.(*mockvmssvmclient.MockInterface)
|
||||||
|
mockVMSSVMClient.EXPECT().List(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any()).Return(expectedVMSSVMs, nil).AnyTimes()
|
||||||
|
if scaleSetName == string(fakeStatusNotFoundVMSSName) {
|
||||||
|
mockVMSSVMClient.EXPECT().Update(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any(), gomock.Any(), gomock.Any()).Return(&retry.Error{HTTPStatusCode: http.StatusNotFound, RawError: cloudprovider.InstanceNotFound}).AnyTimes()
|
||||||
|
} else {
|
||||||
|
mockVMSSVMClient.EXPECT().Update(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
|
||||||
|
}
|
||||||
|
|
||||||
|
diskURI := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/disks/%s",
|
||||||
|
testCloud.SubscriptionID, testCloud.ResourceGroup, *test.existedDisk.Name)
|
||||||
|
|
||||||
|
err = ss.AttachDisk(test.isManagedDisk, "disk-name", diskURI, test.vmssvmName, 0, compute.CachingTypesReadWrite, "", true)
|
||||||
|
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, return error: %v", i, test.desc, err)
|
||||||
|
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected error: %v, return error: %v", i, test.desc, test.expectedErrMsg, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestDetachDiskWithVMSS(t *testing.T) {
|
||||||
|
ctrl := gomock.NewController(t)
|
||||||
|
defer ctrl.Finish()
|
||||||
|
|
||||||
|
fakeStatusNotFoundVMSSName := types.NodeName("FakeStatusNotFoundVMSSName")
|
||||||
|
testCases := []struct {
|
||||||
|
desc string
|
||||||
|
vmList map[string]string
|
||||||
|
vmssVMList []string
|
||||||
|
vmssName types.NodeName
|
||||||
|
vmssvmName types.NodeName
|
||||||
|
existedDisk compute.Disk
|
||||||
|
expectedErr bool
|
||||||
|
expectedErrMsg error
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
desc: "an error shall be returned if it is invalid vmss name",
|
||||||
|
vmssVMList: []string{"vmss-vm-000001"},
|
||||||
|
vmssName: "vm1",
|
||||||
|
vmssvmName: "vm1",
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: true,
|
||||||
|
expectedErrMsg: fmt.Errorf("not a vmss instance"),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "no error shall be returned if everything is good",
|
||||||
|
vmssVMList: []string{"vmss00-vm-000000", "vmss00-vm-000001", "vmss00-vm-000002"},
|
||||||
|
vmssName: "vmss00",
|
||||||
|
vmssvmName: "vmss00-vm-000000",
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: false,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "an error shall be returned if response StatusNotFound",
|
||||||
|
vmssVMList: []string{"vmss00-vm-000000", "vmss00-vm-000001", "vmss00-vm-000002"},
|
||||||
|
vmssName: fakeStatusNotFoundVMSSName,
|
||||||
|
vmssvmName: "vmss00-vm-000000",
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name")},
|
||||||
|
expectedErr: true,
|
||||||
|
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 404, RawError: instance not found"),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "no error shall be returned if everything is good and the attaching disk does not match data disk",
|
||||||
|
vmssVMList: []string{"vmss00-vm-000000", "vmss00-vm-000001", "vmss00-vm-000002"},
|
||||||
|
vmssName: "vmss00",
|
||||||
|
vmssvmName: "vmss00-vm-000000",
|
||||||
|
existedDisk: compute.Disk{Name: to.StringPtr("disk-name-err")},
|
||||||
|
expectedErr: false,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for i, test := range testCases {
|
||||||
|
scaleSetName := string(test.vmssName)
|
||||||
|
ss, err := newTestScaleSet(ctrl)
|
||||||
|
assert.NoError(t, err, test.desc)
|
||||||
|
testCloud := ss.cloud
|
||||||
|
testCloud.PrimaryScaleSetName = scaleSetName
|
||||||
|
expectedVMSS := buildTestVMSS(scaleSetName, []string{testLBBackendpoolID0})
|
||||||
|
mockVMSSClient := testCloud.VirtualMachineScaleSetsClient.(*mockvmssclient.MockInterface)
|
||||||
|
mockVMSSClient.EXPECT().List(gomock.Any(), testCloud.ResourceGroup).Return([]compute.VirtualMachineScaleSet{expectedVMSS}, nil).AnyTimes()
|
||||||
|
mockVMSSClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, scaleSetName).Return(expectedVMSS, nil).MaxTimes(1)
|
||||||
|
mockVMSSClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any()).Return(nil).MaxTimes(1)
|
||||||
|
|
||||||
|
expectedVMSSVMs, _, _ := buildTestVirtualMachineEnv(testCloud, scaleSetName, "", 0, test.vmssVMList, "succeeded")
|
||||||
|
for _, vmssvm := range expectedVMSSVMs {
|
||||||
|
vmssvm.StorageProfile = &compute.StorageProfile{
|
||||||
|
OsDisk: &compute.OSDisk{
|
||||||
|
Name: to.StringPtr("osdisk1"),
|
||||||
|
ManagedDisk: &compute.ManagedDiskParameters{
|
||||||
|
ID: to.StringPtr("ManagedID"),
|
||||||
|
DiskEncryptionSet: &compute.DiskEncryptionSetParameters{
|
||||||
|
ID: to.StringPtr("DiskEncryptionSetID"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
DataDisks: &[]compute.DataDisk{{
|
||||||
|
Lun: to.Int32Ptr(0),
|
||||||
|
Name: to.StringPtr("disk-name"),
|
||||||
|
}},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
mockVMSSVMClient := testCloud.VirtualMachineScaleSetVMsClient.(*mockvmssvmclient.MockInterface)
|
||||||
|
mockVMSSVMClient.EXPECT().List(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any()).Return(expectedVMSSVMs, nil).AnyTimes()
|
||||||
|
if scaleSetName == string(fakeStatusNotFoundVMSSName) {
|
||||||
|
mockVMSSVMClient.EXPECT().Update(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any(), gomock.Any(), gomock.Any()).Return(&retry.Error{HTTPStatusCode: http.StatusNotFound, RawError: cloudprovider.InstanceNotFound}).AnyTimes()
|
||||||
|
} else {
|
||||||
|
mockVMSSVMClient.EXPECT().Update(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
|
||||||
|
}
|
||||||
|
|
||||||
|
diskURI := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/disks/%s",
|
||||||
|
testCloud.SubscriptionID, testCloud.ResourceGroup, *test.existedDisk.Name)
|
||||||
|
|
||||||
|
err = ss.DetachDisk(*test.existedDisk.Name, diskURI, test.vmssvmName)
|
||||||
|
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, err: %v", i, test.desc, err)
|
||||||
|
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected error: %v, return error: %v", i, test.desc, test.expectedErrMsg, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestGetDataDisksWithVMSS(t *testing.T) {
|
||||||
|
ctrl := gomock.NewController(t)
|
||||||
|
defer ctrl.Finish()
|
||||||
|
|
||||||
|
var testCases = []struct {
|
||||||
|
desc string
|
||||||
|
nodeName types.NodeName
|
||||||
|
isDataDiskNull bool
|
||||||
|
expectedDataDisks []compute.DataDisk
|
||||||
|
expectedErr bool
|
||||||
|
expectedErrMsg error
|
||||||
|
crt azcache.AzureCacheReadType
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
desc: "an error shall be returned if there's no corresponding vm",
|
||||||
|
nodeName: "vmss00-vm-000001",
|
||||||
|
expectedDataDisks: nil,
|
||||||
|
expectedErr: true,
|
||||||
|
expectedErrMsg: fmt.Errorf("instance not found"),
|
||||||
|
crt: azcache.CacheReadTypeDefault,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "correct list of data disks shall be returned if everything is good",
|
||||||
|
nodeName: "vmss00-vm-000000",
|
||||||
|
expectedDataDisks: []compute.DataDisk{
|
||||||
|
{
|
||||||
|
Lun: to.Int32Ptr(0),
|
||||||
|
Name: to.StringPtr("disk1"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedErr: false,
|
||||||
|
crt: azcache.CacheReadTypeDefault,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "correct list of data disks shall be returned if everything is good",
|
||||||
|
nodeName: "vmss00-vm-000000",
|
||||||
|
expectedDataDisks: []compute.DataDisk{
|
||||||
|
{
|
||||||
|
Lun: to.Int32Ptr(0),
|
||||||
|
Name: to.StringPtr("disk1"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedErr: false,
|
||||||
|
crt: azcache.CacheReadTypeUnsafe,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "nil shall be returned if DataDisk is null",
|
||||||
|
nodeName: "vmss00-vm-000000",
|
||||||
|
isDataDiskNull: true,
|
||||||
|
expectedDataDisks: nil,
|
||||||
|
expectedErr: false,
|
||||||
|
crt: azcache.CacheReadTypeDefault,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for i, test := range testCases {
|
||||||
|
scaleSetName := string(test.nodeName)
|
||||||
|
ss, err := newTestScaleSet(ctrl)
|
||||||
|
assert.NoError(t, err, test.desc)
|
||||||
|
testCloud := ss.cloud
|
||||||
|
testCloud.PrimaryScaleSetName = scaleSetName
|
||||||
|
expectedVMSS := buildTestVMSS(scaleSetName, []string{testLBBackendpoolID0})
|
||||||
|
mockVMSSClient := testCloud.VirtualMachineScaleSetsClient.(*mockvmssclient.MockInterface)
|
||||||
|
mockVMSSClient.EXPECT().List(gomock.Any(), testCloud.ResourceGroup).Return([]compute.VirtualMachineScaleSet{expectedVMSS}, nil).AnyTimes()
|
||||||
|
mockVMSSClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, scaleSetName).Return(expectedVMSS, nil).MaxTimes(1)
|
||||||
|
mockVMSSClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any()).Return(nil).MaxTimes(1)
|
||||||
|
|
||||||
|
expectedVMSSVMs, _, _ := buildTestVirtualMachineEnv(testCloud, scaleSetName, "", 0, []string{"vmss00-vm-000000"}, "succeeded")
|
||||||
|
if !test.isDataDiskNull {
|
||||||
|
for _, vmssvm := range expectedVMSSVMs {
|
||||||
|
vmssvm.StorageProfile = &compute.StorageProfile{
|
||||||
|
DataDisks: &[]compute.DataDisk{{
|
||||||
|
Lun: to.Int32Ptr(0),
|
||||||
|
Name: to.StringPtr("disk1"),
|
||||||
|
}},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
mockVMSSVMClient := testCloud.VirtualMachineScaleSetVMsClient.(*mockvmssvmclient.MockInterface)
|
||||||
|
mockVMSSVMClient.EXPECT().List(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any()).Return(expectedVMSSVMs, nil).AnyTimes()
|
||||||
|
mockVMSSVMClient.EXPECT().Update(gomock.Any(), testCloud.ResourceGroup, scaleSetName, gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
|
||||||
|
dataDisks, err := ss.GetDataDisks(test.nodeName, test.crt)
|
||||||
|
assert.Equal(t, test.expectedDataDisks, dataDisks, "TestCase[%d]: %s", i, test.desc)
|
||||||
|
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s", i, test.desc)
|
||||||
|
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected error: %v, return error: %v", i, test.desc, test.expectedErrMsg, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
Loading…
Reference in New Issue
Block a user