diff --git a/pkg/kubelet/userns/userns_manager_disabled_test.go b/pkg/kubelet/userns/userns_manager_disabled_test.go index de28a07bc25..12d9ad785b8 100644 --- a/pkg/kubelet/userns/userns_manager_disabled_test.go +++ b/pkg/kubelet/userns/userns_manager_disabled_test.go @@ -21,6 +21,7 @@ import ( "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" + v1 "k8s.io/api/core/v1" utilfeature "k8s.io/apiserver/pkg/util/feature" featuregatetesting "k8s.io/component-base/featuregate/testing" pkgfeatures "k8s.io/kubernetes/pkg/features" @@ -48,14 +49,33 @@ func TestReleaseDisabled(t *testing.T) { func TestGetOrCreateUserNamespaceMappingsDisabled(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, pkgfeatures.UserNamespacesSupport, false)() + tests := []struct { + name string + pod *v1.Pod + success bool + }{ + { + name: "pod is nil", + pod: nil, + success: true, + }, + } - testUserNsPodsManager := &testUserNsPodsManager{} - m, err := MakeUserNsManager(testUserNsPodsManager) - require.NoError(t, err) + for _, test := range tests { + t.Run(test.name, func(t *testing.T) { + testUserNsPodsManager := &testUserNsPodsManager{} + m, err := MakeUserNsManager(testUserNsPodsManager) + require.NoError(t, err) - userns, err := m.GetOrCreateUserNamespaceMappings(nil, "") - assert.NoError(t, err) - assert.Nil(t, userns) + userns, err := m.GetOrCreateUserNamespaceMappings(test.pod, "") + assert.Nil(t, userns) + if test.success { + assert.NoError(t, err) + } else { + assert.Error(t, err) + } + }) + } } func TestCleanupOrphanedPodUsernsAllocationsDisabled(t *testing.T) {