github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 13:07:07 +00:00
Code Issues Projects Releases Wiki Activity

Let image manager return a copy of image list.

Browse Source
This commit is contained in:
Lantao Liu 2018-02-26 19:16:07 +00:00
parent 8d406bf48b
commit 1fb91cc8be
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/kubelet/images/image_gc_manager.go
View File

@ -124,7 +124,7 @@ func (i *imageCache) set(images []container.Image) {
func (i *imageCache) get() []container.Image { func (i *imageCache) get() []container.Image {
i.RLock() i.RLock()
defer i.RUnlock() defer i.RUnlock()
return i.images return append([]container.Image{}, i.images...)
} }
// Information about the images we track. // Information about the images we track.

10
pkg/kubelet/images/image_gc_manager_test.go
View File

@ -548,6 +548,16 @@ func TestValidateImageGCPolicy(t *testing.T) {
} }
} }
func TestImageCacheReturnCopiedList(t *testing.T) {
cache := &imageCache{}
testList := []container.Image{{ID: "1"}, {ID: "2"}}
cache.set(testList)
list := cache.get()
assert.Len(t, list, 2)
list[0].ID = "3"
assert.Equal(t, cache.get(), testList)
}
func uint64Ptr(i uint64) *uint64 { func uint64Ptr(i uint64) *uint64 {
return &i return &i
} }