github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 07:47:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #35664 from ymqytw/update_drain_test

Browse Source 
Automatic merge from submit-queue

Update drain test

Update how int convert to string in the kubectl drain test.
It is safer to use `strconv.Itoa()` than `string()`.
This commit is contained in:
Kubernetes Submit Queue 2016-10-30 04:30:18 -07:00 committed by GitHub
commit 1ff0b422a8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/kubectl/cmd/drain_test.go
View File

@ -26,6 +26,7 @@ import (
"net/url" "net/url"
"os" "os"
"reflect" "reflect"
"strconv"
"strings" "strings"
"testing" "testing"
"time" "time"
@ -658,11 +659,11 @@ func createPods(ifCreateNewPods bool) (map[string]api.Pod, []api.Pod) {
if ifCreateNewPods { if ifCreateNewPods {
uid = types.UID(i) uid = types.UID(i)
} else { } else {
uid = types.UID(string(i) + string(i)) uid = types.UID(strconv.Itoa(i) + strconv.Itoa(i))
} }
pod := api.Pod{ pod := api.Pod{
ObjectMeta: api.ObjectMeta{ ObjectMeta: api.ObjectMeta{
Name: "pod" + string(i), Name: "pod" + strconv.Itoa(i),
Namespace: "default", Namespace: "default",
UID: uid, UID: uid,
Generation: int64(i), Generation: int64(i),