From a9e0a2b09ac5c8481a2de51d12b43c622ed21c05 Mon Sep 17 00:00:00 2001 From: Mike Danese Date: Tue, 20 Feb 2018 15:18:32 -0800 Subject: [PATCH] cloud: don't require application default credentials to run unit tests --- .../gce/gce_loadbalancer_external_test.go | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go b/pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go index 07d4e1c11d9..ed9bd6dcaa8 100644 --- a/pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go +++ b/pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go @@ -18,6 +18,7 @@ package gce import ( "fmt" + "net/http" "testing" "github.com/stretchr/testify/assert" @@ -261,13 +262,16 @@ var apiService = &v1.Service{ }, } -func fakeGCECloud() (*GCECloud, error) { - client, err := newOauthClient(nil) - if err != nil { - return nil, err - } +type fakeRoundTripper struct{} - service, err := compute.New(client) +func (*fakeRoundTripper) RoundTrip(*http.Request) (*http.Response, error) { + return nil, fmt.Errorf("err: test used fake http client") +} + +func fakeGCECloud() (*GCECloud, error) { + c := &http.Client{Transport: &fakeRoundTripper{}} + + service, err := compute.New(c) if err != nil { return nil, err }