From 05e1c4b48930c70ad9b6da4b385ad0e874e80bc5 Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Tue, 17 Jun 2025 09:16:24 +0200 Subject: [PATCH] e2e: node: fix podresources API feature label We want to fix and enhance lanes which exercise the podresources API tests. The first step is to clarify the label and made it specific to podresources API, minimzing the clash and the ambiguity with the "PodLevelResources" feature. Note we change the label names, but the label name is backward compatible (filtering for "Feature:PodResources" will still get the tests). This turns out to be not a problem because these tests are no longer called out explicitly in the lane definitions. We want to change this ASAP. The new name is more specific and allows us to clearly call out tests for this feature in the lane definitions. Signed-off-by: Francesco Romani --- test/e2e/feature/feature.go | 6 ++++-- test/e2e_node/podresources_test.go | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/test/e2e/feature/feature.go b/test/e2e/feature/feature.go index e096674e36f..b13d5706080 100644 --- a/test/e2e/feature/feature.go +++ b/test/e2e/feature/feature.go @@ -352,8 +352,10 @@ var ( // TODO: document the feature (owning SIG, when to use this feature for a test) PodReadyToStartContainersCondition = framework.WithFeature(framework.ValidFeatures.Add("PodReadyToStartContainersCondition")) - // TODO: document the feature (owning SIG, when to use this feature for a test) - PodResources = framework.WithFeature(framework.ValidFeatures.Add("PodResources")) + // Owner: sig-node + // Marks tests which exercise or consume the kubelet-local Pod Resources API + // see: KEPs 606, 2043; see: pkg/kubelet/apis/podresources/ + PodResourcesAPI = framework.WithFeature(framework.ValidFeatures.Add("PodResourcesAPI")) // Owner: sig-node // Verify ProcMount feature. diff --git a/test/e2e_node/podresources_test.go b/test/e2e_node/podresources_test.go index b1e9c840125..8676b96d6c6 100644 --- a/test/e2e_node/podresources_test.go +++ b/test/e2e_node/podresources_test.go @@ -947,7 +947,7 @@ func podresourcesGetTests(ctx context.Context, f *framework.Framework, cli kubel } // Serial because the test updates kubelet configuration. -var _ = SIGDescribe("POD Resources", framework.WithSerial(), feature.PodResources, func() { +var _ = SIGDescribe("POD Resources API", framework.WithSerial(), feature.PodResourcesAPI, func() { f := framework.NewDefaultFramework("podresources-test") f.NamespacePodSecurityLevel = admissionapi.LevelPrivileged