From 20b5205dad419fa79b0c6cd69d01183d21f7d9c5 Mon Sep 17 00:00:00 2001 From: Han Kang Date: Wed, 15 Feb 2023 09:16:16 -0800 Subject: [PATCH] use 10 seconds as the biggest bucket for webhook metrics otherwise charts will top out at 2.5s for webhook latencies --- staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go | 2 +- test/instrumentation/testdata/stable-metrics-list.yaml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go index 8482aea880b..82f2efe4429 100644 --- a/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go +++ b/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go @@ -178,7 +178,7 @@ func newAdmissionMetrics() *AdmissionMetrics { Subsystem: subsystem, Name: "webhook_admission_duration_seconds", Help: "Admission webhook latency histogram in seconds, identified by name and broken out for each operation and API resource and type (validate or admit).", - Buckets: []float64{0.005, 0.025, 0.1, 0.5, 1.0, 2.5}, + Buckets: []float64{0.005, 0.025, 0.1, 0.5, 1.0, 2.5, 10}, StabilityLevel: metrics.STABLE, }, []string{"name", "type", "operation", "rejected"}, diff --git a/test/instrumentation/testdata/stable-metrics-list.yaml b/test/instrumentation/testdata/stable-metrics-list.yaml index 003b0bc8e45..7771aa9b62c 100644 --- a/test/instrumentation/testdata/stable-metrics-list.yaml +++ b/test/instrumentation/testdata/stable-metrics-list.yaml @@ -290,6 +290,7 @@ - 0.5 - 1 - 2.5 + - 10 - name: current_inflight_requests subsystem: apiserver help: Maximal number of currently used inflight request limit of this apiserver