From 210a634bccc4ac49d9bbe405af0c279d96e723c8 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Sun, 25 Sep 2016 10:30:40 -0700 Subject: [PATCH] Remove useless conversion-gen pre-filter --- .../conversion-gen/generators/conversion.go | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/cmd/libs/go2idl/conversion-gen/generators/conversion.go b/cmd/libs/go2idl/conversion-gen/generators/conversion.go index 513cd6e2241..27c39888aa7 100644 --- a/cmd/libs/go2idl/conversion-gen/generators/conversion.go +++ b/cmd/libs/go2idl/conversion-gen/generators/conversion.go @@ -254,33 +254,6 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat getManualDefaultingFunctions(context, context.Universe[pp], manualDefaults) } - pkgNeedsGeneration := false - for _, t := range pkg.Types { - // Check whether this type can be auto-converted to the peer - // package type. - peerType := getPeerTypeFor(context, t, peerPkgs) - if peerType == nil { - // We did not find a corresponding type. - continue - } - if namer.IsPrivateGoName(peerType.Name.Name) { - // We won't be able to convert to a private type. - glog.V(5).Infof(" found a peer type %v, but it is a private name", t) - continue - } - - // If we can generate conversion in any direction, we should - // generate this package. - if isConvertible(t, peerType, manualConversions) || isConvertible(peerType, t, manualConversions) { - pkgNeedsGeneration = true - break - } - } - if !pkgNeedsGeneration { - glog.V(5).Infof(" no viable conversions, not generating for this package") - continue - } - packages = append(packages, &generator.DefaultPackage{ PackageName: filepath.Base(pkg.Path),