From 213d07af8dd0fc715ccaefdd7b0921115bcee352 Mon Sep 17 00:00:00 2001 From: SataQiu Date: Wed, 5 Jun 2019 15:29:59 +0800 Subject: [PATCH] fix some golint failures of pkg/registry --- hack/.golint_failures | 6 ------ .../mutatingwebhookconfiguration/storage/storage.go | 2 +- .../validatingwebhookconfiguration/storage/storage.go | 2 +- pkg/registry/apps/daemonset/storage/storage.go | 4 +++- .../autoscaling/horizontalpodautoscaler/storage/storage.go | 4 +++- pkg/registry/batch/cronjob/storage/storage.go | 1 + pkg/registry/batch/job/storage/storage.go | 2 ++ 7 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hack/.golint_failures b/hack/.golint_failures index 795f37bf204..b4b61ec4aa1 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -195,10 +195,7 @@ pkg/proxy/userspace pkg/proxy/winkernel pkg/proxy/winuserspace pkg/quota/v1/evaluator/core -pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage pkg/registry/admissionregistration/rest -pkg/registry/admissionregistration/validatingwebhookconfiguration/storage -pkg/registry/apps/daemonset/storage pkg/registry/apps/deployment/storage pkg/registry/apps/replicaset pkg/registry/apps/replicaset/storage @@ -211,11 +208,8 @@ pkg/registry/authorization/localsubjectaccessreview pkg/registry/authorization/rest pkg/registry/authorization/selfsubjectaccessreview pkg/registry/authorization/subjectaccessreview -pkg/registry/autoscaling/horizontalpodautoscaler/storage pkg/registry/autoscaling/rest -pkg/registry/batch/cronjob/storage pkg/registry/batch/job -pkg/registry/batch/job/storage pkg/registry/batch/rest pkg/registry/certificates/certificates pkg/registry/certificates/certificates/storage diff --git a/pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage/storage.go b/pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage/storage.go index 7f3be349278..1b6b03097d8 100644 --- a/pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage/storage.go +++ b/pkg/registry/admissionregistration/mutatingwebhookconfiguration/storage/storage.go @@ -24,7 +24,7 @@ import ( "k8s.io/kubernetes/pkg/registry/admissionregistration/mutatingwebhookconfiguration" ) -// rest implements a RESTStorage for pod disruption budgets against etcd +// REST implements a RESTStorage for pod disruption budgets against etcd type REST struct { *genericregistry.Store } diff --git a/pkg/registry/admissionregistration/validatingwebhookconfiguration/storage/storage.go b/pkg/registry/admissionregistration/validatingwebhookconfiguration/storage/storage.go index 6a0bee2f068..f0e1baf8604 100644 --- a/pkg/registry/admissionregistration/validatingwebhookconfiguration/storage/storage.go +++ b/pkg/registry/admissionregistration/validatingwebhookconfiguration/storage/storage.go @@ -24,7 +24,7 @@ import ( "k8s.io/kubernetes/pkg/registry/admissionregistration/validatingwebhookconfiguration" ) -// rest implements a RESTStorage for pod disruption budgets against etcd +// REST implements a RESTStorage for pod disruption budgets against etcd type REST struct { *genericregistry.Store } diff --git a/pkg/registry/apps/daemonset/storage/storage.go b/pkg/registry/apps/daemonset/storage/storage.go index 16f85488182..d13d6f9d5ad 100644 --- a/pkg/registry/apps/daemonset/storage/storage.go +++ b/pkg/registry/apps/daemonset/storage/storage.go @@ -31,7 +31,7 @@ import ( "k8s.io/kubernetes/pkg/registry/apps/daemonset" ) -// rest implements a RESTStorage for DaemonSets +// REST implements a RESTStorage for DaemonSets type REST struct { *genericregistry.Store categories []string @@ -76,6 +76,7 @@ func (r *REST) Categories() []string { return r.categories } +// WithCategories sets categories for REST. func (r *REST) WithCategories(categories []string) *REST { r.categories = categories return r @@ -86,6 +87,7 @@ type StatusREST struct { store *genericregistry.Store } +// New creates a new DaemonSet object. func (r *StatusREST) New() runtime.Object { return &apps.DaemonSet{} } diff --git a/pkg/registry/autoscaling/horizontalpodautoscaler/storage/storage.go b/pkg/registry/autoscaling/horizontalpodautoscaler/storage/storage.go index 2da0772cfee..eb58e9bc8b0 100644 --- a/pkg/registry/autoscaling/horizontalpodautoscaler/storage/storage.go +++ b/pkg/registry/autoscaling/horizontalpodautoscaler/storage/storage.go @@ -31,6 +31,7 @@ import ( "k8s.io/kubernetes/pkg/registry/autoscaling/horizontalpodautoscaler" ) +// REST implements a RESTStorage for pod disruption budgets against etcd type REST struct { *genericregistry.Store } @@ -74,11 +75,12 @@ func (r *REST) Categories() []string { return []string{"all"} } -/// StatusREST implements the REST endpoint for changing the status of a daemonset +// StatusREST implements the REST endpoint for changing the status of a daemonset type StatusREST struct { store *genericregistry.Store } +// New creates a new HorizontalPodAutoscaler object. func (r *StatusREST) New() runtime.Object { return &autoscaling.HorizontalPodAutoscaler{} } diff --git a/pkg/registry/batch/cronjob/storage/storage.go b/pkg/registry/batch/cronjob/storage/storage.go index 3bfacfb777e..d9d1088c592 100644 --- a/pkg/registry/batch/cronjob/storage/storage.go +++ b/pkg/registry/batch/cronjob/storage/storage.go @@ -78,6 +78,7 @@ type StatusREST struct { store *genericregistry.Store } +// New creates a new CronJob object. func (r *StatusREST) New() runtime.Object { return &batch.CronJob{} } diff --git a/pkg/registry/batch/job/storage/storage.go b/pkg/registry/batch/job/storage/storage.go index a874774d420..19a157db775 100644 --- a/pkg/registry/batch/job/storage/storage.go +++ b/pkg/registry/batch/job/storage/storage.go @@ -37,6 +37,7 @@ type JobStorage struct { Status *StatusREST } +// NewStorage creates a new JobStorage against etcd. func NewStorage(optsGetter generic.RESTOptionsGetter) JobStorage { jobRest, jobStatusRest := NewREST(optsGetter) @@ -89,6 +90,7 @@ type StatusREST struct { store *genericregistry.Store } +// New creates a new Job object. func (r *StatusREST) New() runtime.Object { return &batch.Job{} }