From 89ff3b25300c39b23d86754cff563ef8b98b6893 Mon Sep 17 00:00:00 2001 From: derekwaynecarr Date: Tue, 31 May 2016 11:04:46 -0400 Subject: [PATCH] Update kubectl describe pod to use pod level qos --- pkg/kubectl/describe.go | 10 +--------- pkg/kubectl/describe_test.go | 13 ------------- test/e2e/kubectl.go | 2 +- 3 files changed, 2 insertions(+), 23 deletions(-) diff --git a/pkg/kubectl/describe.go b/pkg/kubectl/describe.go index 6d4e4667934..d201bccd6bc 100644 --- a/pkg/kubectl/describe.go +++ b/pkg/kubectl/describe.go @@ -540,6 +540,7 @@ func describePod(pod *api.Pod, events *api.EventList) (string, error) { } } describeVolumes(pod.Spec.Volumes, out, "") + fmt.Fprintf(out, "QoS Tier:\t%s\n", qosutil.GetPodQos(pod)) if events != nil { DescribeEvents(events, out) } @@ -843,15 +844,6 @@ func describeContainers(label string, containers []api.Container, containerStatu } } - resourceToQoS := qosutil.GetQoS(&container) - if len(resourceToQoS) > 0 { - fmt.Fprintf(out, " QoS Tier:\n") - } - for _, resource := range SortedQoSResourceNames(resourceToQoS) { - qos := resourceToQoS[resource] - fmt.Fprintf(out, " %s:\t%s\n", resource, qos) - } - resources := container.Resources if len(resources.Limits) > 0 { fmt.Fprintf(out, " Limits:\n") diff --git a/pkg/kubectl/describe_test.go b/pkg/kubectl/describe_test.go index a9e0a1be0b2..5f1e99fc719 100644 --- a/pkg/kubectl/describe_test.go +++ b/pkg/kubectl/describe_test.go @@ -238,19 +238,6 @@ func TestDescribeContainers(t *testing.T) { }, expectedElements: []string{"test", "State", "Waiting", "Ready", "True", "Restart Count", "7", "Image", "image", "time", "1000"}, }, - // QoS classes - { - container: api.Container{ - Name: "test", - Image: "image", - }, - status: api.ContainerStatus{ - Name: "test", - Ready: true, - RestartCount: 7, - }, - expectedElements: []string{"cpu", "BestEffort", "memory", "BestEffort"}, - }, // Using limits. { container: api.Container{ diff --git a/test/e2e/kubectl.go b/test/e2e/kubectl.go index 47983689352..754309fa4eb 100644 --- a/test/e2e/kubectl.go +++ b/test/e2e/kubectl.go @@ -508,8 +508,8 @@ var _ = framework.KubeDescribe("Kubectl client", func() { {"IP:"}, {"Controllers:", "ReplicationController/redis-master"}, {"Image:", redisImage}, - {"cpu:", "BestEffort"}, {"State:", "Running"}, + {"QoS Tier:", "BestEffort"}, } checkOutput(output, requiredStrings) })