From 22dc4744a079ba68431d4ecc4a4b5f9d3e246f3a Mon Sep 17 00:00:00 2001 From: Gaurav Singh Date: Wed, 8 Jul 2020 17:57:03 -0400 Subject: [PATCH] [test/kubelet]: Fix deadlock in watch manager test Signed-off-by: Gaurav Singh --- test/integration/kubelet/watch_manager_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/integration/kubelet/watch_manager_test.go b/test/integration/kubelet/watch_manager_test.go index 1ca0cc3a709..a065bc26b71 100644 --- a/test/integration/kubelet/watch_manager_test.go +++ b/test/integration/kubelet/watch_manager_test.go @@ -40,6 +40,7 @@ func TestWatchBasedManager(t *testing.T) { server := kubeapiservertesting.StartTestServerOrDie(t, nil, nil, framework.SharedEtcd()) defer server.TearDownFn() + const n = 10 server.ClientConfig.QPS = 10000 server.ClientConfig.Burst = 10000 client, err := kubernetes.NewForConfig(server.ClientConfig) @@ -65,8 +66,8 @@ func TestWatchBasedManager(t *testing.T) { // create 1000 secrets in parallel t.Log(time.Now(), "creating 1000 secrets") wg := sync.WaitGroup{} - errCh := make(chan error, 1) - for i := 0; i < 10; i++ { + errCh := make(chan error, n) + for i := 0; i < n; i++ { wg.Add(1) go func(i int) { defer wg.Done() @@ -93,8 +94,8 @@ func TestWatchBasedManager(t *testing.T) { // fetch all secrets wg = sync.WaitGroup{} - errCh = make(chan error, 1) - for i := 0; i < 10; i++ { + errCh = make(chan error, n) + for i := 0; i < n; i++ { wg.Add(1) go func(i int) { defer wg.Done()