github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-16 14:45:28 +00:00
Code Issues Projects Releases Wiki Activity

azure: loadbalancer rules use DSR

Browse Source
This commit is contained in:
Cole Mickens
2016-08-25 08:43:43 +00:00
parent f6b313b1da
commit 23454c1774
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/cloudprovider/providers/azure/azure_loadbalancer.go
View File

@@ -133,7 +133,7 @@ func (az *Cloud) EnsureLoadBalancer(clusterName string, service *api.Service, no
return nil, utilerrors.Flatten(errs) return nil, utilerrors.Flatten(errs)
} }
glog.V(2).Infof("ensure(%s): FINISH - %s", service.Name, *pip.Properties.IPAddress) glog.V(2).Infof("ensure(%s): FINISH - %s", serviceName, *pip.Properties.IPAddress)
return &api.LoadBalancerStatus{ return &api.LoadBalancerStatus{
Ingress: []api.LoadBalancerIngress{{IP: *pip.Properties.IPAddress}}, Ingress: []api.LoadBalancerIngress{{IP: *pip.Properties.IPAddress}},
}, nil }, nil
@@ -362,8 +362,9 @@ func (az *Cloud) reconcileLoadBalancer(lb network.LoadBalancer, pip *network.Pub
Probe: &network.SubResource{ Probe: &network.SubResource{
ID: to.StringPtr(az.getLoadBalancerProbeID(lbName, lbRuleName)), ID: to.StringPtr(az.getLoadBalancerProbeID(lbName, lbRuleName)),
}, },
FrontendPort: to.Int32Ptr(port.Port), FrontendPort: to.Int32Ptr(port.Port),
BackendPort: to.Int32Ptr(port.NodePort), BackendPort: to.Int32Ptr(port.Port),
EnableFloatingIP: to.BoolPtr(true),
}, },
} }
} }
@@ -470,7 +471,7 @@ func (az *Cloud) reconcileSecurityGroup(sg network.SecurityGroup, clusterName st
Properties: &network.SecurityRulePropertiesFormat{ Properties: &network.SecurityRulePropertiesFormat{
Protocol: securityProto, Protocol: securityProto,
SourcePortRange: to.StringPtr("*"), SourcePortRange: to.StringPtr("*"),
DestinationPortRange: to.StringPtr(strconv.Itoa(int(port.NodePort))), DestinationPortRange: to.StringPtr(strconv.Itoa(int(port.Port))),
SourceAddressPrefix: to.StringPtr("Internet"), SourceAddressPrefix: to.StringPtr("Internet"),
DestinationAddressPrefix: to.StringPtr("*"), DestinationAddressPrefix: to.StringPtr("*"),
Access: network.Allow, Access: network.Allow,

14
pkg/cloudprovider/providers/azure/azure_test.go
View File

@@ -217,7 +217,7 @@ func getTestLoadBalancer(services ...api.Service) network.LoadBalancer {
Name: to.StringPtr(ruleName), Name: to.StringPtr(ruleName),
Properties: &network.LoadBalancingRulePropertiesFormat{ Properties: &network.LoadBalancingRulePropertiesFormat{
FrontendPort: to.Int32Ptr(port.Port), FrontendPort: to.Int32Ptr(port.Port),
BackendPort: to.Int32Ptr(port.NodePort), BackendPort: to.Int32Ptr(port.Port),
}, },
}) })
probes = append(probes, network.Probe{ probes = append(probes, network.Probe{
@@ -248,7 +248,7 @@ func getTestSecurityGroup(services ...api.Service) network.SecurityGroup {
rules = append(rules, network.SecurityRule{ rules = append(rules, network.SecurityRule{
Name: to.StringPtr(ruleName), Name: to.StringPtr(ruleName),
Properties: &network.SecurityRulePropertiesFormat{ Properties: &network.SecurityRulePropertiesFormat{
DestinationPortRange: to.StringPtr(fmt.Sprintf("%d", port.NodePort)), DestinationPortRange: to.StringPtr(fmt.Sprintf("%d", port.Port)),
}, },
}) })
} }
@@ -273,13 +273,13 @@ func validateLoadBalancer(t *testing.T, loadBalancer network.LoadBalancer, servi
for _, actualRule := range *loadBalancer.Properties.LoadBalancingRules { for _, actualRule := range *loadBalancer.Properties.LoadBalancingRules {
if strings.EqualFold(*actualRule.Name, wantedRuleName) && if strings.EqualFold(*actualRule.Name, wantedRuleName) &&
*actualRule.Properties.FrontendPort == wantedRule.Port && *actualRule.Properties.FrontendPort == wantedRule.Port &&
*actualRule.Properties.BackendPort == wantedRule.NodePort { *actualRule.Properties.BackendPort == wantedRule.Port {
foundRule = true foundRule = true
break break
} }
} }
if !foundRule { if !foundRule {
t.Errorf("Expected rule but didn't find it: %q", wantedRuleName) t.Errorf("Expected load balancer rule but didn't find it: %q", wantedRuleName)
} }
foundProbe := false foundProbe := false
@@ -291,7 +291,7 @@ func validateLoadBalancer(t *testing.T, loadBalancer network.LoadBalancer, servi
} }
} }
if !foundProbe { if !foundProbe {
t.Errorf("Expected probe but didn't find it: %q", wantedRuleName) t.Errorf("Expected loadbalancer probe but didn't find it: %q", wantedRuleName)
} }
} }
} }
@@ -315,13 +315,13 @@ func validateSecurityGroup(t *testing.T, securityGroup network.SecurityGroup, se
foundRule := false foundRule := false
for _, actualRule := range *securityGroup.Properties.SecurityRules { for _, actualRule := range *securityGroup.Properties.SecurityRules {
if strings.EqualFold(*actualRule.Name, wantedRuleName) && if strings.EqualFold(*actualRule.Name, wantedRuleName) &&
*actualRule.Properties.DestinationPortRange == fmt.Sprintf("%d", wantedRule.NodePort) { *actualRule.Properties.DestinationPortRange == fmt.Sprintf("%d", wantedRule.Port) {
foundRule = true foundRule = true
break break
} }
} }
if !foundRule { if !foundRule {
t.Errorf("Expected rule but didn't find it: %q", wantedRuleName) t.Errorf("Expected security group rule but didn't find it: %q", wantedRuleName)
} }
} }
} }