From f355b22f5f7027db358ecf239c279ee7d36a15f3 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Mon, 7 Aug 2023 08:53:51 +0000 Subject: [PATCH] implement Stringer for podActions klog prints an internal error when trying to log the podActions struct. > I0505 14:12:12.827065 190662 kuberuntime_manager.go:1014] "computePodActions got for pod" podActions="" pod="kube-system/coredns-8f5847b64-mzw46" Implement the stringer interface on the struct to avoid the json error. Change-Id: I22444524a78a0ecec9490b9240def371a4129434 --- pkg/kubelet/kuberuntime/kuberuntime_manager.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/kubelet/kuberuntime/kuberuntime_manager.go b/pkg/kubelet/kuberuntime/kuberuntime_manager.go index c8e76d41f28..f60b8a5ecc4 100644 --- a/pkg/kubelet/kuberuntime/kuberuntime_manager.go +++ b/pkg/kubelet/kuberuntime/kuberuntime_manager.go @@ -514,6 +514,11 @@ type podActions struct { UpdatePodResources bool } +func (p podActions) String() string { + return fmt.Sprintf("KillPod: %t, CreateSandbox: %t, UpdatePodResources: %t, Attempt: %d, InitContainersToStart: %v, ContainersToStart: %v, EphemeralContainersToStart: %v,ContainersToUpdate: %v, ContainersToKill: %v", + p.KillPod, p.CreateSandbox, p.UpdatePodResources, p.Attempt, p.InitContainersToStart, p.ContainersToStart, p.EphemeralContainersToStart, p.ContainersToUpdate, p.ContainersToKill) +} + func containerChanged(container *v1.Container, containerStatus *kubecontainer.Status) (uint64, uint64, bool) { expectedHash := kubecontainer.HashContainer(container) return expectedHash, containerStatus.Hash, containerStatus.Hash != expectedHash