From 240546cb7f4d80b802cefc325d8c7e1ed9744d49 Mon Sep 17 00:00:00 2001
From: Ted Yu <yute@vmware.com>
Date: Tue, 15 Oct 2019 13:13:19 -0700
Subject: [PATCH] Remove update-storage-objects.sh

---
 cluster/update-storage-objects.sh   | 141 -------------------
 hack/test-update-storage-objects.sh | 210 ----------------------------
 2 files changed, 351 deletions(-)
 delete mode 100755 cluster/update-storage-objects.sh
 delete mode 100755 hack/test-update-storage-objects.sh

diff --git a/cluster/update-storage-objects.sh b/cluster/update-storage-objects.sh
deleted file mode 100755
index 0218526a666..00000000000
--- a/cluster/update-storage-objects.sh
+++ /dev/null
@@ -1,141 +0,0 @@
-#!/usr/bin/env bash
-
-# Copyright 2015 The Kubernetes Authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Script to update etcd objects as per the latest API Version.
-# This just reads all objects and then writes them back as is to ensure that
-# they are written using the latest API version.
-#
-# Steps to use this script to upgrade the cluster to a new version:
-# https://kubernetes.io/docs/tasks/administer-cluster/cluster-management/#upgrading-to-a-different-api-version
-
-set -o errexit
-set -o nounset
-set -o pipefail
-
-KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
-source "${KUBE_ROOT}/hack/lib/init.sh"
-
-KUBECTL="${KUBE_OUTPUT_HOSTBIN}/kubectl"
-
-# List of resources to be updated.
-# TODO: Get this list of resources from server once
-# http://issue.k8s.io/2057 is fixed.
-declare -a resources=(
-    "endpoints"
-    "events"
-    "limitranges"
-    "namespaces"
-    "nodes"
-    "pods"
-    "persistentvolumes"
-    "persistentvolumeclaims"
-    "replicationcontrollers"
-    "resourcequotas"
-    "secrets"
-    "services"
-    "jobs"
-    "horizontalpodautoscalers"
-    "storageclasses"
-    "roles.rbac.authorization.k8s.io"
-    "rolebindings.rbac.authorization.k8s.io"
-    "clusterroles.rbac.authorization.k8s.io"
-    "clusterrolebindings.rbac.authorization.k8s.io"
-    "networkpolicies.networking.k8s.io"
-    "ingresses.networking.k8s.io"
-)
-
-# Find all the namespaces.
-IFS=" " read -r -a namespaces <<< "$("${KUBECTL}" get namespaces -o go-template="{{range.items}}{{.metadata.name}} {{end}}")"
-if [ -z "${namespaces:-}" ]
-then
-  echo "Unexpected: No namespace found. Nothing to do."
-  exit 1
-fi
-
-all_failed=1
-
-for resource in "${resources[@]}"
-do
-  for namespace in "${namespaces[@]}"
-  do
-    # If get fails, assume it's because the resource hasn't been installed in the apiserver.
-    # TODO hopefully we can remove this once we use dynamic discovery of gettable/updateable
-    # resources.
-    set +e
-    IFS=" " read -r -a instances <<< "$("${KUBECTL}" get "${resource}" --namespace="${namespace}" -o go-template="{{range.items}}{{.metadata.name}} {{end}}")"
-    result=$?
-    set -e
-
-    if [[ "${all_failed}" -eq 1 && "${result}" -eq 0 ]]; then
-      all_failed=0
-    fi
-
-    # Nothing to do if there is no instance of that resource.
-    if [[ -z "${instances:-}" ]]
-    then
-      continue
-    fi
-    for instance in "${instances[@]}"
-    do
-      # Read and then write it back as is.
-      # Update can fail if the object was updated after we fetched the
-      # object, but before we could update it. We, hence, try the update
-      # operation multiple times. But 5 continuous failures indicate some other
-      # problem.
-      success=0
-      for (( tries=0; tries<5; ++tries ))
-      do
-        filename="/tmp/k8s-${namespace}-${resource}-${instance}.json"
-        ( "${KUBECTL}" get "${resource}" "${instance}" --namespace="${namespace}" -o json > "${filename}" ) || true
-        if [[ ! -s "${filename}" ]]
-        then
-          # This happens when the instance has been deleted. We can hence ignore
-          # this instance.
-          echo "Looks like ${instance} got deleted. Ignoring it"
-          success=1
-          break
-        fi
-        output=$("${KUBECTL}" replace -f "${filename}" --namespace="${namespace}") || true
-        rm "${filename}"
-        if [ -n "${output:-}" ]
-        then
-          success=1
-          break
-        fi
-      done
-      if [[ "${success}" -eq 0 ]]
-      then
-        echo "Error: failed to update ${resource}/${instance} in ${namespace} namespace after 5 tries"
-        exit 1
-      fi
-    done
-    if [[ "${resource}" == "namespaces" ]] || [[ "${resource}" == "nodes" ]]
-    then
-      # These resources are namespace agnostic. No need to update them for every
-      # namespace.
-      break
-    fi
-  done
-done
-
-if [[ "${all_failed}" -eq 1 ]]; then
-  echo "kubectl get failed for all resources"
-  exit 1
-fi
-
-echo "All objects updated successfully!!"
-
-exit 0
diff --git a/hack/test-update-storage-objects.sh b/hack/test-update-storage-objects.sh
deleted file mode 100755
index 98cea3d12bb..00000000000
--- a/hack/test-update-storage-objects.sh
+++ /dev/null
@@ -1,210 +0,0 @@
-#!/usr/bin/env bash
-
-# Copyright 2014 The Kubernetes Authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Script to test cluster/update-storage-objects.sh works as expected.
-
-set -o errexit
-set -o nounset
-set -o pipefail
-
-KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
-source "${KUBE_ROOT}/hack/lib/init.sh"
-
-# The api version in which objects are currently stored in etcd.
-KUBE_OLD_API_VERSION=${KUBE_OLD_API_VERSION:-"v1"}
-# The api version in which our etcd objects should be converted to.
-# The new api version
-KUBE_NEW_API_VERSION=${KUBE_NEW_API_VERSION:-"v1"}
-
-KUBE_OLD_STORAGE_VERSIONS=${KUBE_OLD_STORAGE_VERSIONS:-""}
-KUBE_NEW_STORAGE_VERSIONS=${KUBE_NEW_STORAGE_VERSIONS:-""}
-
-KUBE_STORAGE_MEDIA_TYPE_JSON="application/json"
-KUBE_STORAGE_MEDIA_TYPE_PROTOBUF="application/vnd.kubernetes.protobuf"
-
-ETCD_HOST=${ETCD_HOST:-127.0.0.1}
-ETCD_PORT=${ETCD_PORT:-2379}
-ETCD_PREFIX=${ETCD_PREFIX:-randomPrefix}
-API_PORT=${API_PORT:-8080}
-API_HOST=${API_HOST:-127.0.0.1}
-RUNTIME_CONFIG=""
-
-ETCDCTL=$(which etcdctl)
-KUBECTL="${KUBE_OUTPUT_HOSTBIN}/kubectl"
-UPDATE_ETCD_OBJECTS_SCRIPT="${KUBE_ROOT}/cluster/update-storage-objects.sh"
-DISABLE_ADMISSION_PLUGINS="ServiceAccount,NamespaceLifecycle,LimitRanger,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,PersistentVolumeLabel,DefaultStorageClass,StorageObjectInUseProtection"
-
-function startApiServer() {
-  local storage_versions=${1:-""}
-  local storage_media_type=${2:-""}
-  kube::log::status "Starting kube-apiserver with..."
-  kube::log::status "                        storage-media-type: ${storage_media_type}"
-  kube::log::status "                            runtime-config: ${RUNTIME_CONFIG}"
-  kube::log::status "                 storage-version overrides: ${storage_versions}"
-
-  "${KUBE_OUTPUT_HOSTBIN}/kube-apiserver" \
-    --insecure-bind-address="${API_HOST}" \
-    --bind-address="${API_HOST}" \
-    --insecure-port="${API_PORT}" \
-    --storage-backend="etcd3" \
-    --etcd-servers="http://${ETCD_HOST}:${ETCD_PORT}" \
-    --etcd-prefix="/${ETCD_PREFIX}" \
-    --runtime-config="${RUNTIME_CONFIG}" \
-    --disable-admission-plugins="${DISABLE_ADMISSION_PLUGINS}" \
-    --cert-dir="${TMPDIR:-/tmp/}" \
-    --service-cluster-ip-range="10.0.0.0/24" \
-    --storage-versions="${storage_versions}" \
-    --storage-media-type="${storage_media_type}" 1>&2 &
-  APISERVER_PID=$!
-
-  # url, prefix, wait, times
-  kube::util::wait_for_url "http://${API_HOST}:${API_PORT}/healthz" "apiserver: " 1 120
-}
-
-function killApiServer() {
-  kube::log::status "Killing api server"
-  if [[ -n ${APISERVER_PID-} ]]; then
-    kill ${APISERVER_PID} 1>&2 2>/dev/null
-    wait ${APISERVER_PID} || true
-    kube::log::status "api server exited"
-  fi
-  unset APISERVER_PID
-}
-
-function cleanup() {
-  killApiServer
-
-  kube::etcd::cleanup
-
-  kube::log::status "Clean up complete"
-}
-
-trap cleanup EXIT SIGINT
-
-make -C "${KUBE_ROOT}" WHAT=cmd/kube-apiserver
-
-kube::etcd::start
-echo "${ETCD_VERSION}" > "${ETCD_DIR}/version.txt"
-
-### BEGIN TEST DEFINITION CUSTOMIZATION ###
-
-# source_file,resource,namespace,name,old_version,new_version
-tests=(
-"test/e2e/testing-manifests/rbd-storage-class.yaml,storageclasses,,slow,v1beta1,v1"
-)
-
-KUBE_OLD_API_VERSION="networking.k8s.io/v1,storage.k8s.io/v1beta1,extensions/v1beta1"
-KUBE_NEW_API_VERSION="networking.k8s.io/v1,storage.k8s.io/v1beta1,storage.k8s.io/v1,extensions/v1beta1,policy/v1beta1"
-KUBE_OLD_STORAGE_VERSIONS="storage.k8s.io/v1beta1"
-KUBE_NEW_STORAGE_VERSIONS="storage.k8s.io/v1beta1,storage.k8s.io/v1"
-
-### END TEST DEFINITION CUSTOMIZATION ###
-
-#######################################################
-# Step 1: Start a server which supports both the old and new api versions,
-# but KUBE_OLD_API_VERSION is the latest (storage) version.
-# Additionally use KUBE_STORAGE_MEDIA_TYPE_JSON for storage encoding.
-#######################################################
-RUNTIME_CONFIG="api/all=false,api/v1=true,apiregistration.k8s.io/v1=true,${KUBE_OLD_API_VERSION}=true,${KUBE_NEW_API_VERSION}=true"
-startApiServer ${KUBE_OLD_STORAGE_VERSIONS} ${KUBE_STORAGE_MEDIA_TYPE_JSON}
-
-
-# Create object(s)
-for test in "${tests[@]}"; do
-  IFS=',' read -ra test_data <<<"$test"
-  source_file=${test_data[0]}
-
-  kube::log::status "Creating ${source_file}"
-  ${KUBECTL} create -f "${KUBE_ROOT}/${source_file}"
-
-  # Verify that the storage version is the old version
-  resource=${test_data[1]}
-  namespace=${test_data[2]}
-  name=${test_data[3]}
-  old_storage_version=${test_data[4]}
-
-  if [ -n "${namespace}" ]; then
-    namespace="${namespace}/"
-  fi
-  kube::log::status "Verifying ${resource}/${namespace}${name} has storage version ${old_storage_version} in etcd"
-  ETCDCTL_API=3 ${ETCDCTL} --endpoints="http://${ETCD_HOST}:${ETCD_PORT}" get "/${ETCD_PREFIX}/${resource}/${namespace}${name}" | grep "${old_storage_version}"
-done
-
-killApiServer
-
-
-#######################################################
-# Step 2: Start a server which supports both the old and new api versions,
-# but KUBE_NEW_API_VERSION is the latest (storage) version.
-# Still use KUBE_STORAGE_MEDIA_TYPE_JSON for storage encoding.
-#######################################################
-
-RUNTIME_CONFIG="api/all=false,api/v1=true,apiregistration.k8s.io/v1=true,${KUBE_OLD_API_VERSION}=true,${KUBE_NEW_API_VERSION}=true"
-startApiServer ${KUBE_NEW_STORAGE_VERSIONS} ${KUBE_STORAGE_MEDIA_TYPE_JSON}
-
-# Update etcd objects, so that will now be stored in the new api version.
-kube::log::status "Updating storage versions in etcd"
-${UPDATE_ETCD_OBJECTS_SCRIPT}
-
-# Verify that the storage version was changed in etcd
-for test in "${tests[@]}"; do
-  IFS=',' read -ra test_data <<<"$test"
-  resource=${test_data[1]}
-  namespace=${test_data[2]}
-  name=${test_data[3]}
-  new_storage_version=${test_data[5]}
-
-  if [ -n "${namespace}" ]; then
-    namespace="${namespace}/"
-  fi
-  kube::log::status "Verifying ${resource}/${namespace}${name} has updated storage version ${new_storage_version} in etcd"
-  ETCDCTL_API=3 ${ETCDCTL} --endpoints="http://${ETCD_HOST}:${ETCD_PORT}" get "/${ETCD_PREFIX}/${resource}/${namespace}${name}" | grep "${new_storage_version}"
-done
-
-killApiServer
-
-
-#######################################################
-# Step 3 : Start a server which supports only the new api version.
-# However, change storage encoding to KUBE_STORAGE_MEDIA_TYPE_PROTOBUF.
-#######################################################
-
-RUNTIME_CONFIG="api/all=false,api/v1=true,apiregistration.k8s.io/v1=true,${KUBE_NEW_API_VERSION}=true"
-
-# This seems to reduce flakiness.
-sleep 1
-startApiServer ${KUBE_NEW_STORAGE_VERSIONS} ${KUBE_STORAGE_MEDIA_TYPE_PROTOBUF}
-
-for test in "${tests[@]}"; do
-  IFS=',' read -ra test_data <<<"$test"
-  resource=${test_data[1]}
-  namespace=${test_data[2]}
-  name=${test_data[3]}
-  namespace_flag=""
-
-  # Verify that the server is able to read the object.
-  if [ -n "${namespace}" ]; then
-    namespace_flag="--namespace=${namespace}"
-    namespace="${namespace}/"
-  fi
-  kube::log::status "Verifying we can retrieve ${resource}/${namespace}${name} via kubectl"
-  # We have to remove the cached discovery information about the old version; otherwise,
-  # the 'kubectl get' will use that and fail to find the resource.
-  rm -rf "${HOME}/.kube/cache/discovery/localhost_8080/${KUBE_OLD_STORAGE_VERSIONS}"
-  ${KUBECTL} get "${namespace_flag}" "${resource}/${name}"
-done
-
-killApiServer