github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 12:07:47 +00:00
Code Issues Projects Releases Wiki Activity

No need to check nil iterating gengo Inputs

Browse Source
This commit is contained in:
Tim Hockin 2024-01-16 22:06:35 -08:00
parent 7a084b3352
commit 242b4e27c0
No known key found for this signature in database
4 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go
View File

@ -225,10 +225,6 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
klog.V(3).Infof("pre-processing pkg %q", i) klog.V(3).Infof("pre-processing pkg %q", i)
pkg := context.Universe[i] pkg := context.Universe[i]
if pkg == nil {
// If the input had no Go files, for example.
continue
}
// Only generate conversions for packages which explicitly request it // Only generate conversions for packages which explicitly request it
// by specifying one or more "+k8s:conversion-gen=<peer-pkg>" // by specifying one or more "+k8s:conversion-gen=<peer-pkg>"

5
staging/src/k8s.io/code-generator/cmd/deepcopy-gen/generators/deepcopy.go
View File

@ -138,11 +138,8 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
for _, i := range context.Inputs { for _, i := range context.Inputs {
klog.V(3).Infof("Considering pkg %q", i) klog.V(3).Infof("Considering pkg %q", i)
pkg := context.Universe[i] pkg := context.Universe[i]
if pkg == nil {
// If the input had no Go files, for example.
continue
}
ptag := extractEnabledTag(pkg.Comments) ptag := extractEnabledTag(pkg.Comments)
ptagValue := "" ptagValue := ""

8
staging/src/k8s.io/code-generator/cmd/defaulter-gen/generators/defaulter.go
View File

@ -244,10 +244,6 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
klog.V(5).Infof("considering pkg %q", i) klog.V(5).Infof("considering pkg %q", i)
pkg := context.Universe[i] pkg := context.Universe[i]
if pkg == nil {
// If the input had no Go files, for example.
continue
}
// if the types are not in the same package where the defaulter functions to be generated // if the types are not in the same package where the defaulter functions to be generated
inputTags := extractInputTag(pkg.Comments) inputTags := extractInputTag(pkg.Comments)
@ -299,10 +295,6 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
for _, i := range context.Inputs { for _, i := range context.Inputs {
pkg := context.Universe[i] pkg := context.Universe[i]
if pkg == nil {
// If the input had no Go files, for example.
continue
}
// typesPkg is where the types that needs defaulter are defined. // typesPkg is where the types that needs defaulter are defined.
// Sometimes it is different from pkg. For example, kubernetes core/v1 // Sometimes it is different from pkg. For example, kubernetes core/v1

5
staging/src/k8s.io/code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go
View File

@ -187,11 +187,8 @@ func GetTargets(context *generator.Context, args *args.Args) []generator.Target
for _, i := range context.Inputs { for _, i := range context.Inputs {
klog.V(5).Infof("Considering pkg %q", i) klog.V(5).Infof("Considering pkg %q", i)
pkg := context.Universe[i] pkg := context.Universe[i]
if pkg == nil {
// If the input had no Go files, for example.
continue
}
ptag := extractTag(tagEnabledName, pkg.Comments) ptag := extractTag(tagEnabledName, pkg.Comments)
pkgNeedsGeneration := false pkgNeedsGeneration := false