github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-14 13:45:06 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #30609 from m1093782566/update-comment-info

Browse Source 
Automatic merge from submit-queue

update comment info for scheduler binding fails

Since the process logic for scheduler binding failed has changed, I think we should update the comment information to avoid make people confused :)

The related issue is #30611.

@wojtek-t What do you think about it ?

Thanks!
This commit is contained in:
Kubernetes Submit Queue
2016-08-19 15:47:33 -07:00
committed by GitHub
parent 9bc8240f1a 40f5d64411
commit 248e508225
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugin/pkg/scheduler/scheduler.go
View File

@@ -111,12 +111,8 @@ func (s *Scheduler) scheduleOne() {
// Optimistically assume that the binding will succeed and send it to apiserver // Optimistically assume that the binding will succeed and send it to apiserver
// in the background. // in the background.
// The only risk in this approach is that if the binding fails because of some // If the binding fails, scheduler will release resources allocated to assumed pod
// reason, scheduler will be assuming that it succeeded while scheduling next // immediately.
// pods, until the assumption in the internal cache expire (expiration is
// defined as "didn't read the binding via watch within a given timeout",
// timeout is currently set to 30s). However, after this timeout, the situation
// will self-repair.
assumed := *pod assumed := *pod
assumed.Spec.NodeName = dest assumed.Spec.NodeName = dest
if err := s.config.SchedulerCache.AssumePod(&assumed); err != nil { if err := s.config.SchedulerCache.AssumePod(&assumed); err != nil {