github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #100808 from nicomitchell/scheduler_perf_tests_unique_names

Browse Source 
test/integration/scheduler_perf: make sure each testCase and workload has a unique name
This commit is contained in:
Kubernetes Prow Robot 2021-04-10 19:03:30 -07:00 committed by GitHub
commit 24b40c4d6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/integration/scheduler_perf/scheduler_perf_test.go
View File

@ -111,6 +111,17 @@ func (tc *testCase) collectsMetrics() bool {
return false return false
} }
func (tc *testCase) workloadNamesUnique() error {
workloadUniqueNames := map[string]bool{}
for _, w := range tc.Workloads {
if workloadUniqueNames[w.Name] {
return fmt.Errorf("%s: workload name %s is not unique", tc.Name, w.Name)
}
workloadUniqueNames[w.Name] = true
}
return nil
}
// workload is a subtest under a testCase that tests the scheduler performance // workload is a subtest under a testCase that tests the scheduler performance
// for a certain ordering of ops. The set of nodes created and pods scheduled // for a certain ordering of ops. The set of nodes created and pods scheduled
// in a workload may be heterogeneous. // in a workload may be heterogeneous.
@ -766,10 +777,18 @@ func validateTestCases(testCases []*testCase) error {
if len(testCases) == 0 { if len(testCases) == 0 {
return fmt.Errorf("no test cases defined") return fmt.Errorf("no test cases defined")
} }
testCaseUniqueNames := map[string]bool{}
for _, tc := range testCases { for _, tc := range testCases {
if testCaseUniqueNames[tc.Name] {
return fmt.Errorf("%s: name is not unique", tc.Name)
}
testCaseUniqueNames[tc.Name] = true
if len(tc.Workloads) == 0 { if len(tc.Workloads) == 0 {
return fmt.Errorf("%s: no workloads defined", tc.Name) return fmt.Errorf("%s: no workloads defined", tc.Name)
} }
if err := tc.workloadNamesUnique(); err != nil {
return err
}
if len(tc.WorkloadTemplate) == 0 { if len(tc.WorkloadTemplate) == 0 {
return fmt.Errorf("%s: no ops defined", tc.Name) return fmt.Errorf("%s: no ops defined", tc.Name)
} }