From 6d6b0be36bfcd8faa2d4033d34feb71c341286cc Mon Sep 17 00:00:00 2001 From: SataQiu Date: Mon, 2 Sep 2019 17:47:08 +0800 Subject: [PATCH] fix golint failures of pkg/kubelet --- hack/.golint_failures | 1 - pkg/kubelet/reason_cache.go | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hack/.golint_failures b/hack/.golint_failures index 9043d859031..fe301fb3c2d 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -110,7 +110,6 @@ pkg/kubeapiserver pkg/kubeapiserver/options pkg/kubectl/cmd/convert pkg/kubectl/cmd/get -pkg/kubelet pkg/kubelet/apis/config pkg/kubelet/apis/config/v1beta1 pkg/kubelet/apis/deviceplugin/v1beta1 diff --git a/pkg/kubelet/reason_cache.go b/pkg/kubelet/reason_cache.go index 4c42ab8a7ce..60327baf954 100644 --- a/pkg/kubelet/reason_cache.go +++ b/pkg/kubelet/reason_cache.go @@ -40,8 +40,8 @@ type ReasonCache struct { cache *lru.Cache } -// Reason is the cached item in ReasonCache -type reasonItem struct { +// ReasonItem is the cached item in ReasonCache +type ReasonItem struct { Err error Message string } @@ -64,7 +64,7 @@ func (c *ReasonCache) composeKey(uid types.UID, name string) string { func (c *ReasonCache) add(uid types.UID, name string, reason error, message string) { c.lock.Lock() defer c.lock.Unlock() - c.cache.Add(c.composeKey(uid, name), reasonItem{reason, message}) + c.cache.Add(c.composeKey(uid, name), ReasonItem{reason, message}) } // Update updates the reason cache with the SyncPodResult. Only SyncResult with @@ -93,13 +93,13 @@ func (c *ReasonCache) Remove(uid types.UID, name string) { // Get gets error reason from the cache. The return values are error reason, error message and // whether an error reason is found in the cache. If no error reason is found, empty string will // be returned for error reason and error message. -func (c *ReasonCache) Get(uid types.UID, name string) (*reasonItem, bool) { +func (c *ReasonCache) Get(uid types.UID, name string) (*ReasonItem, bool) { c.lock.Lock() defer c.lock.Unlock() value, ok := c.cache.Get(c.composeKey(uid, name)) if !ok { return nil, false } - info := value.(reasonItem) + info := value.(ReasonItem) return &info, true }