From 252a956150e7862255961007c74a31cd89a362bf Mon Sep 17 00:00:00 2001 From: Hongchao Deng Date: Tue, 12 Jan 2016 08:46:35 -0800 Subject: [PATCH] return error if got InsufficientResourceError and fit=true --- plugin/pkg/scheduler/generic_scheduler.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugin/pkg/scheduler/generic_scheduler.go b/plugin/pkg/scheduler/generic_scheduler.go index b7ffc232759..b54ae91d4f1 100644 --- a/plugin/pkg/scheduler/generic_scheduler.go +++ b/plugin/pkg/scheduler/generic_scheduler.go @@ -129,8 +129,12 @@ func findNodesThatFit(pod *api.Pod, machineToPods map[string][]*api.Pod, predica for name, predicate := range predicateFuncs { fit, err := predicate(pod, machineToPods[node.Name], node.Name) if err != nil { - switch err.(type) { + switch e := err.(type) { case *predicates.InsufficientResourceError: + if fit { + err := fmt.Errorf("got InsufficientResourceError: %v, but also fit='true' which is unexpected", e) + return api.NodeList{}, FailedPredicateMap{}, err + } default: return api.NodeList{}, FailedPredicateMap{}, err }