github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-11 06:02:18 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7213 from wojtek-t/fix_conversion_benchmarks

Browse Source 
Verify conversion results
This commit is contained in:
Filip Grzadkowski
2015-04-23 11:22:13 +02:00
parent cf824ae5e0 7e2724e14b
commit 2532fe56c3
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/conversion/conversion_test.go
View File

@@ -38,15 +38,20 @@ func BenchmarkPodConversion(b *testing.B) {
} }
scheme := api.Scheme.Raw() scheme := api.Scheme.Raw()
var result *api.Pod
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
versionedObj, err := scheme.ConvertToVersion(&pod, testapi.Version()) versionedObj, err := scheme.ConvertToVersion(&pod, testapi.Version())
if err != nil { if err != nil {
b.Fatalf("Conversion error: %v", err) b.Fatalf("Conversion error: %v", err)
} }
_, err = scheme.ConvertToVersion(versionedObj, scheme.InternalVersion) obj, err := scheme.ConvertToVersion(versionedObj, scheme.InternalVersion)
if err != nil { if err != nil {
b.Fatalf("Conversion error: %v", err) b.Fatalf("Conversion error: %v", err)
} }
result = obj.(*api.Pod)
}
if !api.Semantic.DeepDerivative(pod, *result) {
b.Fatalf("Incorrect conversion: expected %v, got %v", pod, result)
} }
} }
@@ -61,15 +66,20 @@ func BenchmarkNodeConversion(b *testing.B) {
} }
scheme := api.Scheme.Raw() scheme := api.Scheme.Raw()
var result *api.Node
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
versionedObj, err := scheme.ConvertToVersion(&node, testapi.Version()) versionedObj, err := scheme.ConvertToVersion(&node, testapi.Version())
if err != nil { if err != nil {
b.Fatalf("Conversion error: %v", err) b.Fatalf("Conversion error: %v", err)
} }
_, err = scheme.ConvertToVersion(versionedObj, scheme.InternalVersion) obj, err := scheme.ConvertToVersion(versionedObj, scheme.InternalVersion)
if err != nil { if err != nil {
b.Fatalf("Conversion error: %v", err) b.Fatalf("Conversion error: %v", err)
} }
result = obj.(*api.Node)
}
if !api.Semantic.DeepDerivative(node, *result) {
b.Fatalf("Incorrect conversion: expected %v, got %v", node, result)
} }
} }
@@ -84,14 +94,19 @@ func BenchmarkReplicationControllerConversion(b *testing.B) {
} }
scheme := api.Scheme.Raw() scheme := api.Scheme.Raw()
var result *api.ReplicationController
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
versionedObj, err := scheme.ConvertToVersion(&replicationController, testapi.Version()) versionedObj, err := scheme.ConvertToVersion(&replicationController, testapi.Version())
if err != nil { if err != nil {
b.Fatalf("Conversion error: %v", err) b.Fatalf("Conversion error: %v", err)
} }
_, err = scheme.ConvertToVersion(versionedObj, scheme.InternalVersion) obj, err := scheme.ConvertToVersion(versionedObj, scheme.InternalVersion)
if err != nil { if err != nil {
b.Fatalf("Conversion error: %v", err) b.Fatalf("Conversion error: %v", err)
} }
result = obj.(*api.ReplicationController)
}
if !api.Semantic.DeepDerivative(replicationController, *result) {
b.Fatalf("Incorrect conversion: expected %v, got %v", replicationController, result)
} }
} }