github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

kubelet: avoid deprecation remark for traditional logging flags

Browse Source 
Just because the options can now also be set via a configuration file does not
mean that the command line flags should not be used anymore.
This commit is contained in:
Patrick Ohly 2021-11-03 12:02:48 +01:00
parent 4df70dfd41
commit 25907036ea
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/kubelet/app/options/options.go
View File

@ -391,7 +391,20 @@ func AddKubeletConfigFlags(mainfs *pflag.FlagSet, c *kubeletconfig.KubeletConfig
// e.g. if a flag was added after this deprecation function, it may not be at the end // e.g. if a flag was added after this deprecation function, it may not be at the end
// of its lifetime yet, even if the rest are. // of its lifetime yet, even if the rest are.
deprecated := "This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information." deprecated := "This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information."
// Some flags are permanently (?) meant to be available. In
// Kubernetes 1.23, the following options were added to
// LoggingConfiguration (long-term goal, more complete
// configuration file) but deprecating the flags seemed
// premature.
notDeprecated := map[string]bool{
"v": true,
"vmodule": true,
"log-flush-frequency": true,
}
fs.VisitAll(func(f *pflag.Flag) { fs.VisitAll(func(f *pflag.Flag) {
if notDeprecated[f.Name] {
return
}
f.Deprecated = deprecated f.Deprecated = deprecated
}) })
mainfs.AddFlagSet(fs) mainfs.AddFlagSet(fs)