From 65122c6f05b45d4be8507d21ae0e4e6733f70248 Mon Sep 17 00:00:00 2001 From: Shijun Qin Date: Wed, 28 Feb 2018 20:17:56 +0800 Subject: [PATCH] Fix: remove keyword defer in the loop Appearance of defer keyword inside a loop structure may caused resource leaks, it's not recommended to do it although it is in an unit test. Releasing a resource just after finishing using it is the highest effective solution, so remove defer is just OK. --- cmd/kubeadm/app/cmd/reset_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/kubeadm/app/cmd/reset_test.go b/cmd/kubeadm/app/cmd/reset_test.go index 2fcfc232e33..a9a71a00467 100644 --- a/cmd/kubeadm/app/cmd/reset_test.go +++ b/cmd/kubeadm/app/cmd/reset_test.go @@ -149,7 +149,6 @@ func TestConfigDirCleaner(t *testing.T) { if err != nil { t.Errorf("Unable to create temporary directory: %s", err) } - defer os.RemoveAll(tmpDir) for _, createDir := range test.setupDirs { err := os.Mkdir(filepath.Join(tmpDir, createDir), 0700) @@ -164,7 +163,7 @@ func TestConfigDirCleaner(t *testing.T) { if err != nil { t.Errorf("Unable to create test file: %s", err) } - defer f.Close() + f.Close() } resetConfigDir(tmpDir, filepath.Join(tmpDir, "pki")) @@ -183,6 +182,8 @@ func TestConfigDirCleaner(t *testing.T) { for _, path := range test.verifyNotExists { assertNotExists(t, filepath.Join(tmpDir, path)) } + + os.RemoveAll(tmpDir) } }