From b109a585398bbfc48ed5e8d42929666ef8f82d70 Mon Sep 17 00:00:00 2001 From: mantuliu <240951888@qq.com> Date: Sat, 22 Apr 2023 15:55:29 +0800 Subject: [PATCH] Improve the performance of isPodStatusCacheTerminal --- pkg/kubelet/pod_workers.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/kubelet/pod_workers.go b/pkg/kubelet/pod_workers.go index e5805dbcf78..a598a29b1ee 100644 --- a/pkg/kubelet/pod_workers.go +++ b/pkg/kubelet/pod_workers.go @@ -716,19 +716,17 @@ func (p *podWorkers) IsPodForMirrorPodTerminatingByFullName(podFullName string) } func isPodStatusCacheTerminal(status *kubecontainer.PodStatus) bool { - runningContainers := 0 - runningSandboxes := 0 for _, container := range status.ContainerStatuses { if container.State == kubecontainer.ContainerStateRunning { - runningContainers++ + return false } } for _, sb := range status.SandboxStatuses { if sb.State == runtimeapi.PodSandboxState_SANDBOX_READY { - runningSandboxes++ + return false } } - return runningContainers == 0 && runningSandboxes == 0 + return true } // UpdatePod carries a configuration change or termination state to a pod. A pod is either runnable,