diff --git a/hack/benchmark-go.sh b/hack/benchmark-go.sh index 3753f6b6bc5..842cfeb6c61 100755 --- a/hack/benchmark-go.sh +++ b/hack/benchmark-go.sh @@ -20,4 +20,4 @@ set -o pipefail KUBE_ROOT=$(dirname "${BASH_SOURCE}")/.. -KUBE_COVER=" " KUBE_RACE=" " "${KUBE_ROOT}/hack/test-go.sh" "" -test.run="^X" -benchtime=1s -bench=. -benchmem +KUBE_COVER="" KUBE_RACE=" " "${KUBE_ROOT}/hack/test-go.sh" "" -test.run="^X" -benchtime=1s -bench=. -benchmem diff --git a/hack/test-go.sh b/hack/test-go.sh index de5c5693714..dfc0f62d3bf 100755 --- a/hack/test-go.sh +++ b/hack/test-go.sh @@ -40,14 +40,13 @@ kube::test::find_dirs() { ) } -kube::test::find_pkgs() { - kube::test::find_dirs | xargs -n1 printf "${KUBE_GO_PACKAGE}/%s\n" -} - # -covermode=atomic becomes default with -race in Go >=1.3 KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout 120s} -KUBE_COVER=${KUBE_COVER:-} # use KUBE_COVER="-cover -covermode=atomic" for full coverage +KUBE_COVER=${KUBE_COVER:-} # set to nonempty string to enable coverage collection +KUBE_COVERMODE=${KUBE_COVERMODE:-atomic} KUBE_RACE=${KUBE_RACE:-} # use KUBE_RACE="-race" to enable race testing +# Set to the goveralls binary path to report coverage results to Coveralls.io. +KUBE_GOVERALLS_BIN=${KUBE_GOVERALLS_BIN:-} kube::test::usage() { kube::log::usage_from_stdin <${combined_cover_profile} fi -kube::test::find_pkgs | xargs go test "${goflags[@]:+${goflags[@]}}" \ - ${KUBE_RACE} \ - ${KUBE_TIMEOUT} \ - ${KUBE_COVER} +if [[ -n "${1-}" ]]; then + test_dirs=$@ +else + test_dirs=$(kube::test::find_dirs) +fi + +# Run all specified tests, optionally collecting coverage if KUBE_COVER is set. +for arg in ${test_dirs}; do + trap 'exit 1' SIGINT + pkg=${KUBE_GO_PACKAGE}/${arg} + + cover_params=() + cover_profile="" + if [[ -n "${KUBE_COVER}" ]]; then + cover_profile=${cover_report_dir}/${arg}/coverage.out + mkdir -p "${cover_report_dir}/${arg}" + cover_params=(-cover -covermode="${KUBE_COVERMODE}" -coverprofile="${cover_profile}") + fi + + go test "${goflags[@]:+${goflags[@]}}" \ + ${KUBE_RACE} \ + ${KUBE_TIMEOUT} \ + "${cover_params[@]+${cover_params[@]}}" \ + "${pkg}" + if [[ -f "${cover_profile}" ]]; then + # Include all coverage reach data in the combined profile, but exclude the + # 'mode' lines, as there should be only one. + grep -h -v "^mode:" ${cover_profile} >>${combined_cover_profile} || true + fi +done + +if [[ -f ${combined_cover_profile} ]]; then + coverage_html_file="${cover_report_dir}/combined-coverage.html" + go tool cover -html="${combined_cover_profile}" -o="${coverage_html_file}" + kube::log::status "Combined coverage report: ${coverage_html_file}" + if [[ -x "${KUBE_GOVERALLS_BIN}" ]]; then + ${KUBE_GOVERALLS_BIN} -coverprofile="${combined_cover_profile}" || true + fi +fi