github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

refactor static analysis code

Browse Source 
Change-Id: I888585cc151e97fee08889a57fc20118733a60a5
This commit is contained in:
Han Kang 2022-11-01 15:56:25 -07:00
parent 12d58d0875
commit 26b7e3a1e9
1 changed files with 25 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
test/instrumentation/decode_metric.go
View File

@ -146,6 +146,9 @@ func (c *metricDecoder) decodeDesc(ce *ast.CallExpr) (metric, error) {
} }
m.ConstLabels = cLabels m.ConstLabels = cLabels
sl, err := decodeStabilityLevel(ce.Args[4], "metrics") sl, err := decodeStabilityLevel(ce.Args[4], "metrics")
if err != nil {
return *m, newDecodeErrorf(ce, "can't decode stability level")
}
if sl != nil { if sl != nil {
m.StabilityLevel = string(*sl) m.StabilityLevel = string(*sl)
} }
@ -189,7 +192,24 @@ func (c *metricDecoder) decodeString(expr ast.Expr) (*string, error) {
return &n, nil return &n, nil
} }
} }
case *ast.SelectorExpr:
s, ok := e.X.(*ast.Ident)
if !ok {
return nil, newDecodeErrorf(e, errExprNotIdent, e.X)
}
variableExpr, found := c.variables[strings.Join([]string{s.Name, e.Sel.Name}, ".")]
if !found {
return nil, newDecodeErrorf(e, errBadImportedVariableAttribute)
}
bl, ok := variableExpr.(*ast.BasicLit)
if !ok {
return nil, newDecodeErrorf(e, errNonStringAttribute)
}
value, err := stringValue(bl)
if err != nil {
return nil, newDecodeErrorf(e, err.Error())
}
return &value, nil
} }
return nil, fmt.Errorf("can't decode string") return nil, fmt.Errorf("can't decode string")
} }
@ -819,29 +839,11 @@ func (c *metricDecoder) decodeBuildFQNameArguments(fc *ast.CallExpr) (string, st
} }
strArgs := make([]string, len(fc.Args)) strArgs := make([]string, len(fc.Args))
for i, elt := range fc.Args { for i, elt := range fc.Args {
switch arg := elt.(type) { s, err := c.decodeString(elt)
case *ast.BasicLit: if err != nil || s == nil {
if arg.Kind != token.STRING { return "", "", "", newDecodeErrorf(fc, err.Error())
return "", "", "", newDecodeErrorf(fc, "can't decode fq name args")
}
strArgs[i] = strings.Trim(arg.Value, `"`)
case *ast.Ident:
s, err := c.decodeString(arg)
if err != nil {
return "", "", "", newDecodeErrorf(fc, "can't decode fq name args")
}
strArgs[i] = *s
case *ast.SelectorExpr:
id, ok := arg.X.(*ast.Ident)
expr, ok := c.variables[id.Name+"."+arg.Sel.Name]
if ok {
s, err := c.decodeString(expr)
if err != nil {
return "", "", "", newDecodeErrorf(fc, "can't decode fq name args")
}
strArgs[i] = *s
}
} }
strArgs[i] = *s
} }
return strArgs[0], strArgs[1], strArgs[2], nil return strArgs[0], strArgs[1], strArgs[2], nil
} }